Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

2021-11-06 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sat, 6 Nov 2021 15:29:57 -0400 Jason Merrill wrote: > On 11/6/21 14:28, Marek Polacek wrote: > > On Sat, Nov 06, 2021 at 02:32:26AM +0100, Bernhard Reutner-Fischer wrote: > > No, I want q to point into the copy of the string, since I'm about > > to modify it. And I'd prefer a single call

Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

2021-11-06 Thread Jason Merrill via Gcc-patches
On 11/6/21 14:28, Marek Polacek wrote: On Sat, Nov 06, 2021 at 02:32:26AM +0100, Bernhard Reutner-Fischer wrote: On 6 November 2021 01:21:43 CET, Marek Polacek via Gcc-patches wrote: Thanks, so like this? I'm including an incremental diff so that it's clear what changed: diff --git

Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

2021-11-06 Thread Marek Polacek via Gcc-patches
On Sat, Nov 06, 2021 at 02:32:26AM +0100, Bernhard Reutner-Fischer wrote: > On 6 November 2021 01:21:43 CET, Marek Polacek via Gcc-patches > wrote: > > > > >Thanks, so like this? I'm including an incremental diff so that it's > >clear what changed: > > > >diff --git a/gcc/attribs.c

Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

2021-11-05 Thread Bernhard Reutner-Fischer via Gcc-patches
On 6 November 2021 01:21:43 CET, Marek Polacek via Gcc-patches wrote: > >Thanks, so like this? I'm including an incremental diff so that it's >clear what changed: > >diff --git a/gcc/attribs.c b/gcc/attribs.c >index d5fba7f4bbb..addfe6f6c80 100644 >--- a/gcc/attribs.c >+++ b/gcc/attribs.c >@@

[PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

2021-11-05 Thread Marek Polacek via Gcc-patches
On Fri, Nov 05, 2021 at 02:48:31PM -0400, Jason Merrill wrote: > On 9/28/21 16:20, Marek Polacek wrote: > > On Thu, Sep 23, 2021 at 02:25:16PM -0400, Jason Merrill wrote: > > > On 9/20/21 18:59, Marek Polacek via Gcc-patches wrote: > > > > + handle_ignored_attributes_option (); > > > > +