Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-28 Thread Jason Merrill
On 11/28/23 11:03, Thomas Schwinge wrote: Hi! On 2023-11-17T14:50:45+, Alex Coplan wrote: --- a/gcc/cp/cp-objcp-common.cc +++ b/gcc/cp/cp-objcp-common.cc +/* Table of features for __has_{feature,extension}. */ + +static constexpr cp_feature_info cp_feature_table[] = +{ + { "cxx_except

Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-28 Thread Alex Coplan
On 28/11/2023 17:03, Thomas Schwinge wrote: > Hi! > > On 2023-11-17T14:50:45+, Alex Coplan wrote: > > --- a/gcc/cp/cp-objcp-common.cc > > +++ b/gcc/cp/cp-objcp-common.cc > > > +/* Table of features for __has_{feature,extension}. */ > > + > > +static constexpr cp_feature_info cp_feature_tabl

Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-28 Thread Thomas Schwinge
Hi! On 2023-11-17T14:50:45+, Alex Coplan wrote: > --- a/gcc/cp/cp-objcp-common.cc > +++ b/gcc/cp/cp-objcp-common.cc > +/* Table of features for __has_{feature,extension}. */ > + > +static constexpr cp_feature_info cp_feature_table[] = > +{ > + { "cxx_exceptions", &flag_exceptions }, > + {

Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-27 Thread Alex Coplan
On 23/11/2023 12:41, Marek Polacek wrote: > On Mon, Nov 20, 2023 at 05:29:58PM -0500, Jason Merrill wrote: > > On 11/17/23 09:50, Alex Coplan wrote: > > > Hi, > > > > > > This is a v5 patch to address Marek's feedback here: > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html

Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-23 Thread Marek Polacek
On Mon, Nov 20, 2023 at 05:29:58PM -0500, Jason Merrill wrote: > On 11/17/23 09:50, Alex Coplan wrote: > > Hi, > > > > This is a v5 patch to address Marek's feedback here: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html > > > > I also implemented Jason's suggestion to use

Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-20 Thread Jason Merrill
On 11/17/23 09:50, Alex Coplan wrote: Hi, This is a v5 patch to address Marek's feedback here: https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html I also implemented Jason's suggestion to use constexpr for the tables from this review: https://gcc.gnu.org/pipermail/gcc-patches/20

[PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

2023-11-17 Thread Alex Coplan
Hi, This is a v5 patch to address Marek's feedback here: https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html I also implemented Jason's suggestion to use constexpr for the tables from this review: https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634484.html I'll attach the