Re: [PATCH v8 08/12] Give better error messages for musttail

2024-07-08 Thread Andi Kleen
On Mon, Jul 08, 2024 at 09:06:21AM +0200, Richard Biener wrote: > On Sat, Jul 6, 2024 at 8:45 PM Andi Kleen wrote: > > > > > >if (!single_succ_p (bb)) > > > > -return; > > > > +{ > > > > + int num_eh, num_other; > > > > + bb_get_succ_edge_count (bb, num_eh, num_other); > > >

Re: [PATCH v8 08/12] Give better error messages for musttail

2024-07-08 Thread Richard Biener
On Sat, Jul 6, 2024 at 8:45 PM Andi Kleen wrote: > > > >if (!single_succ_p (bb)) > > > -return; > > > +{ > > > + int num_eh, num_other; > > > + bb_get_succ_edge_count (bb, num_eh, num_other); > > > + /* Allow EH edges so that we can give a better > > > +error

Re: [PATCH v8 08/12] Give better error messages for musttail

2024-07-06 Thread Andi Kleen
> >if (!single_succ_p (bb)) > > -return; > > +{ > > + int num_eh, num_other; > > + bb_get_succ_edge_count (bb, num_eh, num_other); > > + /* Allow EH edges so that we can give a better > > +error message later. */ > > Please instead use

Re: [PATCH v8 08/12] Give better error messages for musttail

2024-07-05 Thread Richard Biener
On Sat, Jun 22, 2024 at 9:01 PM Andi Kleen wrote: > > When musttail is set, make tree-tailcall give error messages > when it cannot handle a call. This avoids vague "other reasons" > error messages later at expand time when it sees a musttail > function not marked tail call. > > In various cases

[PATCH v8 08/12] Give better error messages for musttail

2024-06-22 Thread Andi Kleen
When musttail is set, make tree-tailcall give error messages when it cannot handle a call. This avoids vague "other reasons" error messages later at expand time when it sees a musttail function not marked tail call. In various cases this requires delaying the error until the call is discovered.