Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2023-06-23 Thread Qing Zhao via Gcc-patches
Hi, Alexandre, > On Jun 21, 2023, at 9:16 PM, Alexandre Oliva wrote: > > Hello, Qing, > > On Jun 16, 2023, Qing Zhao wrote: > >> As I mentioned in the previous round of review, I think that the >> documentation >> might need to add more details on what’s the LEAFY mode, >> The purpose of it

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2023-06-21 Thread Alexandre Oliva via Gcc-patches
Hello, Qing, On Jun 16, 2023, Qing Zhao wrote: > As I mentioned in the previous round of review, I think that the documentation > might need to add more details on what’s the LEAFY mode, > The purpose of it, and how to use it, provide more details to the end-users. I'm afraid I'm having diffic

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2023-06-16 Thread Qing Zhao via Gcc-patches
Hi, Alexandre, > On Jun 16, 2023, at 3:26 AM, Alexandre Oliva wrote: > > Hello, Qing, > > On Oct 27, 2022, Qing Zhao wrote: > > >> On Oct 26, 2022, at 5:29 PM, Alexandre Oliva wrote: >>> I'm sure there are other scenarios i

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2023-06-16 Thread Alexandre Oliva via Gcc-patches
Hello, Qing, On Oct 27, 2022, Qing Zhao wrote: > On Oct 26, 2022, at 5:29 PM, Alexandre Oliva wrote: >> I'm sure there are other scenarios in which keeping at least the >> possibility of 'all' is useful. > Okay. > i.e, inste

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2022-10-27 Thread Qing Zhao via Gcc-patches
> On Oct 26, 2022, at 5:29 PM, Alexandre Oliva wrote: > > On Oct 25, 2022, Qing Zhao wrote: > >>> 'all' for leaf functions is likely wasteful. If no other functions are >>> called, one can determine exactly which registers might carry >>> information out and thus need zeroing, and 'used' is

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2022-10-26 Thread Alexandre Oliva via Gcc-patches
On Oct 25, 2022, Qing Zhao wrote: >> 'all' for leaf functions is likely wasteful. If no other functions are >> called, one can determine exactly which registers might carry >> information out and thus need zeroing, and 'used' is thus likely enough, >> depending on the purpose of register scrubbi

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2022-10-25 Thread Qing Zhao via Gcc-patches
Hi, Alexandre, > On Oct 24, 2022, at 10:48 PM, Alexandre Oliva wrote: > > Hello, Qing, > > It was a pleasure to meet you at the Cauldron. Me too! > > > On Oct 21, 2022, Qing Zhao wrote: > >> Hi, Alexandre, >> Could you please explain a little bit on the motivation of this patch first? > >

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2022-10-24 Thread Alexandre Oliva via Gcc-patches
Hello, Qing, It was a pleasure to meet you at the Cauldron. On Oct 21, 2022, Qing Zhao wrote: > Hi, Alexandre, > Could you please explain a little bit on the motivation of this patch first? It was a suggestion I got after the Cauldron presentation. It made sense to me, and was easy enough to

Re: [PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2022-10-21 Thread Qing Zhao via Gcc-patches
Hi, Alexandre, Could you please explain a little bit on the motivation of this patch first? thanks. Qing > On Oct 21, 2022, at 3:31 AM, Alexandre Oliva wrote: > > Introduce 'leafy' to auto-select between 'used' and 'all' for leaf and > nonleaf functions, respectively. > > Regstrapped on x86_

[PATCH zero-call-used-regs] Add leafy mode for zero-call-used-regs

2022-10-21 Thread Alexandre Oliva via Gcc-patches
Introduce 'leafy' to auto-select between 'used' and 'all' for leaf and nonleaf functions, respectively. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog * doc/extend.texi (zero-call-used-regs): Document leafy and variants thereof. * flag-types.h (zero_