Re: [PATCHv3] Add a warning for invalid function casts

2017-12-14 Thread Jason Merrill
On Thu, Dec 7, 2017 at 3:48 PM, Bernd Edlinger wrote: > On 12/06/17 23:35, Jason Merrill wrote: >> On Fri, Dec 1, 2017 at 7:42 AM, Bernd Edlinger >> wrote: >>> this version of the patch improves the heuristic check to take the >>> target hook into account, to handle cases correctly when both or o

Re: [PATCHv3] Add a warning for invalid function casts

2017-12-14 Thread Bernd Edlinger
On 12/07/17 21:48, Bernd Edlinger wrote: > On 12/06/17 23:35, Jason Merrill wrote: >> On Fri, Dec 1, 2017 at 7:42 AM, Bernd Edlinger >> wrote: >>> this version of the patch improves the heuristic check to take the >>> target hook into account, to handle cases correctly when both or only >>> one pa

Re: [PATCHv3] Add a warning for invalid function casts

2017-12-07 Thread Bernd Edlinger
On 12/06/17 23:35, Jason Merrill wrote: > On Fri, Dec 1, 2017 at 7:42 AM, Bernd Edlinger > wrote: >> this version of the patch improves the heuristic check to take the >> target hook into account, to handle cases correctly when both or only >> one parameter is _not_ promoted to int. > > In lookin

Re: [PATCHv3] Add a warning for invalid function casts

2017-12-06 Thread Jason Merrill
On Fri, Dec 1, 2017 at 7:42 AM, Bernd Edlinger wrote: > this version of the patch improves the heuristic check to take the > target hook into account, to handle cases correctly when both or only > one parameter is _not_ promoted to int. In looking at this, I discovered that the argument to promot

[PATCHv3] Add a warning for invalid function casts

2017-12-01 Thread Bernd Edlinger
Hi, this version of the patch improves the heuristic check to take the target hook into account, to handle cases correctly when both or only one parameter is _not_ promoted to int. Both C and C++ FE should of course use the same logic here. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. Is