Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-14 Thread Richard Biener
On Fri, 2 Aug 2019, Bernd Edlinger wrote: > On 8/2/19 3:11 PM, Richard Biener wrote: > > On Tue, 30 Jul 2019, Bernd Edlinger wrote: > > > >> > >> I have no test coverage for the movmisalign optab though, so I > >> rely on your code review for that part. > > > > It looks OK. I tried to make it t

Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-02 Thread Bernd Edlinger
On 8/2/19 3:11 PM, Richard Biener wrote: > On Tue, 30 Jul 2019, Bernd Edlinger wrote: > >> >> I have no test coverage for the movmisalign optab though, so I >> rely on your code review for that part. > > It looks OK. I tried to make it trigger on the following on > i?86 with -msse2: > > typedef

Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-02 Thread Richard Biener
On Tue, 30 Jul 2019, Bernd Edlinger wrote: > Hi Richard, > > it is already a while ago, but I had not found time to continue > with this patch until now. > > I think I have now a better solution, which properly addresses your > comments below. > > On 3/25/19 9:41 AM, Richard Biener wrote: > > O

Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-02 Thread Richard Earnshaw (lists)
On 01/08/2019 12:19, Bernd Edlinger wrote: On 7/31/19 3:16 PM, Richard Earnshaw (lists) wrote: On 30/07/2019 21:51, Bernd Edlinger wrote: +/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft -mabi=aapcs -O3" } */ This isn't going to work as-is, we test many combinati

Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-01 Thread Bernd Edlinger
On 7/31/19 3:16 PM, Richard Earnshaw (lists) wrote: > > > On 30/07/2019 21:51, Bernd Edlinger wrote: >> +/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft >> -mabi=aapcs -O3" } */ > > This isn't going to work as-is, we test many combinations of the compiler, > either w

Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-07-31 Thread Richard Earnshaw (lists)
On 30/07/2019 21:51, Bernd Edlinger wrote: +/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft -mabi=aapcs -O3" } */ This isn't going to work as-is, we test many combinations of the compiler, either with explicit dejagnu settings or with the compiler defaults and t

[PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-07-30 Thread Bernd Edlinger
Hi Richard, it is already a while ago, but I had not found time to continue with this patch until now. I think I have now a better solution, which properly addresses your comments below. On 3/25/19 9:41 AM, Richard Biener wrote: > On Fri, 22 Mar 2019, Bernd Edlinger wrote: > >> On 3/21/19 12:15