Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-05-19 Thread Jason Merrill
On 05/06/2016 10:23 AM, Andres Tiraboschi wrote: +static tree +eval_call_plugin_callback (const constexpr_ctx *ctx, tree fun, + bool lval, bool *non_constant_p, bool *overflow_p) This function needs a comment. -static void +void cxx_bind_parameters_in_call (const con

Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-05-06 Thread Andres Tiraboschi
Hi I made the corrections to the patch. Changelog 2016-5-6 Andres Tiraboschi *gcc/plugin.c (PLUGIN_EVAL_CALL_CONSTEXPR): New event. *gcc/plugin.def (PLUGIN_EVAL_CALL_CONSTEXPR): New event. *gcc/cp/constexpr.c (constexpr_fundef): Moved to gcc/cp/constexpr.h. *gcc/cp/constexpr.c (

Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-05-05 Thread Andres Tiraboschi
Hi, thanks for the feedback, I'll do the changes. 2016-05-04 13:16 GMT-03:00 Jason Merrill : > On 05/02/2016 03:28 PM, Andres Tiraboschi wrote: >> >> + constexpr_call_info call_info; >> + call_info.function = t; >> + call_info.call_stack = call_stack; >> + call_info.ctx = ctx; >> + call_info.

Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-05-04 Thread Jason Merrill
On 05/02/2016 03:28 PM, Andres Tiraboschi wrote: + constexpr_call_info call_info; + call_info.function = t; + call_info.call_stack = call_stack; + call_info.ctx = ctx; + call_info.lval_p = lval; + call_info.non_constant_p = non_constant_p; + call_info.overflow_p = overflow_p; + call_info.

Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-05-02 Thread Andres Tiraboschi
2016-04-26 10:41 GMT-03:00 Andres Tiraboschi : > Hi, thanks for answering, > > 2016-04-25 16:21 GMT-03:00 Jason Merrill : >> Let's create a constexpr.h rather than expose constexpr internals to all of >> the front end. Really, I'd prefer to avoid exposing them at all. Why does >> what you want to

Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-04-26 Thread Andres Tiraboschi
Hi, thanks for answering, 2016-04-25 16:21 GMT-03:00 Jason Merrill : > Let's create a constexpr.h rather than expose constexpr internals to all of > the front end. Really, I'd prefer to avoid exposing them at all. Why does > what you want to do require all this implementation detail? Ok, you are

Re: [PING][PATCH] New plugin event when evaluating a constexpr call

2016-04-25 Thread Jason Merrill
On 04/25/2016 10:08 AM, Andres Tiraboschi wrote: *gcc/cp/constexpr.c (constexpr_fundef): Moved to gcc/cp/cp-tree.h. *gcc/cp/constexpr.c (constexpr_call): Ditto. *gcc/cp/constexpr.c (constexpr_ctx): Ditto. Let's create a constexpr.h rather than expose constexpr internals to all o

[PING][PATCH] New plugin event when evaluating a constexpr call

2016-04-25 Thread Andres Tiraboschi
Hi This patch adds a plugin event when evaluating a call expression in constexpr. The goal of this patch is to allow the plugins to analyze and or modify the evaluation of constant expressions. Changelog 2016-4-25 Andres Tiraboschi *gcc/plugin.c (PLUGIN_EVAL_CALL_CONSTEXPR): New event.