Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-07-01 Thread Jonathan Wakely
On 30/06/14 19:17 -0700, Tim Shen wrote: On Sat, Jun 28, 2014 at 2:45 AM, Jonathan Wakely wrote: On 28/06/14 00:18 -0700, Tim Shen wrote: Please put a space above this new function, otherwise it looks like the "Dummy implementations" comment applies to this function, but in fact that function i

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-30 Thread Tim Shen
On Sat, Jun 28, 2014 at 2:45 AM, Jonathan Wakely wrote: > On 28/06/14 00:18 -0700, Tim Shen wrote: > Please put a space above this new function, otherwise it looks like > the "Dummy implementations" comment applies to this function, but in > fact that function is used for dfs mode. > > Similarly,

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-28 Thread Jonathan Wakely
On 28/06/14 00:18 -0700, Tim Shen wrote: diff --git a/libstdc++-v3/include/bits/regex_executor.h b/libstdc++-v3/include/bits/regex_executor.h index 1991c00..e02fa65 100644 --- a/libstdc++-v3/include/bits/regex_executor.h +++ b/libstdc++-v3/include/bits/regex_executor.h @@ -173,6 +173,8 @@ _GLIBC

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-28 Thread Tim Shen
On Tue, Jun 10, 2014 at 1:56 PM, Tim Shen wrote: > On Tue, Jun 10, 2014 at 9:54 AM, Jonathan Wakely wrote: >> I'm sure this is because I still don't understand all the regex code, >> but doesn't this change mean that for an "extended" mode regex with >> backrefs, the user could define _GLIBCXX_RE

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-10 Thread Tim Shen
On Tue, Jun 10, 2014 at 9:54 AM, Jonathan Wakely wrote: > I'm sure this is because I still don't understand all the regex code, > but doesn't this change mean that for an "extended" mode regex with > backrefs, the user could define _GLIBCXX_REGEX_USE_THOMPSON_NFA and > backrefs wouldn't work? Sor

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-10 Thread Jonathan Wakely
diff --git a/libstdc++-v3/include/bits/regex.tcc b/libstdc++-v3/include/bits/regex.tcc index a81f517..6a1faaf 100644 --- a/libstdc++-v3/include/bits/regex.tcc +++ b/libstdc++-v3/include/bits/regex.tcc @@ -70,7 +70,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION // without defining a macro. Users shou

[PR 61424] std::regex matches right to left, not leftmost longest

2014-06-06 Thread Tim Shen
Here's a patch that is a little bit "quick & dirty". In BFS mode it's not trivial to support ECMAScript's "match from left to right". A quick solution is only using DFS for ECMAScript. See the patch. It is possible to support ECMAScript's "left to right" in BFS mode (re2 does this), but I didn't s