Re: [PR 87059] kludge over MIN_EXPR problem causing VRP failure in value ranges

2018-08-25 Thread Aldy Hernandez
Agreed. Thank you Martin! On Sat, Aug 25, 2018, 21:19 Jeff Law wrote: > On 08/24/2018 10:50 AM, Aldy Hernandez wrote: > > As discussed in the PR, the MIN_EXPR being passed to VRP has > > incompatible signs. I expect MIN_EXPR to have the same type for all > > arguments plus the MIN_EXPR node its

Re: [PR 87059] kludge over MIN_EXPR problem causing VRP failure in value ranges

2018-08-25 Thread Jeff Law
On 08/24/2018 10:50 AM, Aldy Hernandez wrote: > As discussed in the PR, the MIN_EXPR being passed to VRP has > incompatible signs.  I expect MIN_EXPR to have the same type for all > arguments plus the MIN_EXPR node itself, but this is not the case. > > The culprit on PPC is expand_builtin_strncmp,

[PR 87059] kludge over MIN_EXPR problem causing VRP failure in value ranges

2018-08-24 Thread Aldy Hernandez
As discussed in the PR, the MIN_EXPR being passed to VRP has incompatible signs. I expect MIN_EXPR to have the same type for all arguments plus the MIN_EXPR node itself, but this is not the case. The culprit on PPC is expand_builtin_strncmp, but fixing it there causes other problems on x86-64