Re: [PR middle-end/82123] 00/06 Use EVRP range data in sprintf warnings

2018-02-20 Thread Jeff Law
On 02/20/2018 05:00 PM, Joseph Myers wrote: > Does this help with any of the cases in bug 80776 that weren't already > fixed, or are those distinct despite looking similar? > I don't think so. THe __builtin_unreachable markers are removed by vrp1 -- well before the sprintf warning code gets run.

Re: [PR middle-end/82123] 00/06 Use EVRP range data in sprintf warnings

2018-02-20 Thread Joseph Myers
Does this help with any of the cases in bug 80776 that weren't already fixed, or are those distinct despite looking similar? -- Joseph S. Myers jos...@codesourcery.com

[PR middle-end/82123] 00/06 Use EVRP range data in sprintf warnings

2018-02-20 Thread Jeff Law
So I'm finally getting back to this. To recap, the issue here is the sprintf pass is querying global range information. As a result the range for the key object is not narrowed by the conditionals leading to the sprintf call and we get a false positive (pr81592 and pr82123). The plan for the las