Re: [PR72741] Encode OpenACC 'routine' directive's level of parallelism inside Fortran module files

2019-03-21 Thread Thomas Koenig
Hi Thomas, Are there any further questions, or am I good to commit my patch as posted? Problem is, I have never looked into module writing / reading in any detail, so it will take a few days for me to get up to speed so I can really review your patch. If, in the meantime, maybe somebody else

Re: [PR72741] Encode OpenACC 'routine' directive's level of parallelism inside Fortran module files

2019-03-21 Thread Thomas Schwinge
then this will be necessary > anyway (several of these bits can then in fact appear). Committed to trunk in r269854 "[testsuite, Fortran] Provide 'dg-compile-aux-modules' in 'gfortran.dg/goacc/goacc.exp'", r269855 "[PR72741] Encode OpenACC 'routine' directive's level of parallelis

Re: [PR72741] Encode OpenACC 'routine' directive's level of parallelism inside Fortran module files

2019-03-20 Thread Thomas Schwinge
Hi! Are there any further questions, or am I good to commit my patch as posted? On Thu, 14 Mar 2019 08:38:30 +0100, I wrote: > On Wed, 13 Mar 2019 23:13:46 +0100, Thomas Koenig > wrote: > > Am 13.03.19 um 18:50 schrieb Thomas Schwinge: > > >> There are many ways to deal with it without bumping

Re: [PR72741] Encode OpenACC 'routine' directive's level of parallelism inside Fortran module files

2019-03-14 Thread Thomas Schwinge
Hi Thomas! On Wed, 13 Mar 2019 23:13:46 +0100, Thomas Koenig wrote: > Am 13.03.19 um 18:50 schrieb Thomas Schwinge: > >> There are many ways to deal with it without bumping MOD_VERSION in a > >> backwards but not forwards compatible way, so that a newer compiler will be > >> able to parse old

Re: [PR72741] Encode OpenACC 'routine' directive's level of parallelism inside Fortran module files

2019-03-13 Thread Thomas Koenig
Am 13.03.19 um 18:50 schrieb Thomas Schwinge: There are many ways to deal with it without bumping MOD_VERSION in a backwards but not forwards compatible way, so that a newer compiler will be able to parse old *.mod files, and newer compiler new ones as long as this problematic stuff doesn't

[PR72741] Encode OpenACC 'routine' directive's level of parallelism inside Fortran module files

2019-03-13 Thread Thomas Schwinge
r effort will be recorded in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. Grüße Thomas >From b2f200d24d040c6d34b5b4421e4cb1be9786030f Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 13 Mar 2019 18:39:53 +0100 Subject: [PATCH] [PR72741] Encode OpenACC 'routine