Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-19 Thread Steve Kargl
On Tue, Sep 19, 2017 at 10:26:52PM +0200, Dominique d'Humières wrote: > > I am really upset by the time spent on warning at the expense > of more serious problems. > https://tinyurl.com/y6wunnk9 https://gcc.gnu.org/ml/fortran/2017-09/msg00065.html or this is a consequence

Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-19 Thread Dominique d'Humières
> Le 19 sept. 2017 à 21:59, Thomas Koenig a écrit : > > Am 18.09.2017 um 11:50 schrieb Dominique d'Humières: >> Warning: Conversion from 'REAL(4)' to 'REAL(8)' at (1) [-Wconversion-extra] > > Not me (not in the general case) > >> even if may allow to detect things such

Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-19 Thread Thomas Koenig
Am 18.09.2017 um 11:50 schrieb Dominique d'Humières: Warning: Conversion from 'REAL(4)' to 'REAL(8)' at (1) [-Wconversion-extra] Not me (not in the general case) even if may allow to detect things such as ‘pi8=acos(-1.0)’? This one would be interesting to catch (even with -Wall), although

Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-18 Thread Dominique d'Humières
As said in bugzilla, I am against this change. If you want to use -Wconversion-extra, just add it to your favorite options. -Wconversion-extra is extremely noisy and -Wextra has been stable for some years. IMO we cannot afford to have people complaining about the change. If you really want a

Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-18 Thread Janus Weil
> As a sidenote, I made an observation that is not directly related to > the patch: The second warning in the test case, on "i4 = i8" shows > [-Wconversion] when compiled with -Wall, but [-Wconversion-extra] when > compiled with -Wextra. Does anyone understand how that inconsistency > comes about?

Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-18 Thread Janus Weil
Hi Thomas, >> here is a small patch that enables -Wconversion-extra with -Wextra and >> updates the documentation. > > I grepped for warn_conversion_extra and found 14 occurrences in the > gfortran source tree. > > Are we sure we want to enable each of these warnings with -Wextra? I'd say: Yes,

Re: [Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-17 Thread Thomas Koenig
Hi Janus, here is a small patch that enables -Wconversion-extra with -Wextra and updates the documentation. I grepped for warn_conversion_extra and found 14 occurrences in the gfortran source tree. Are we sure we want to enable each of these warnings with -Wextra? Regards Thomas

[Patch, Fortran] PR 82018: -Wextra should imply -Wconversion-extra

2017-09-16 Thread Janus Weil
Hi all, here is a small patch that enables -Wconversion-extra with -Wextra and updates the documentation. Up to gfortran 5, the warning in the test case was enabled by -Wconversion, and thus with -Wall. That was changed by Thomas in r224190, which makes complete sense to me. However, I think