Re: [Patch, Fortran] PR57785 - Fix folding of dot_product for complex vars

2013-07-08 Thread Tobias Burnus
Am 03.07.2013 14:05, schrieb Tobias Burnus: Thanks goes to Dominique for debugging the issue! Build and regtested on x86-64-gnu-linux. OK for the trunk? I think one should also backport it to 4.7/4.8. (Folding - and hence the bug - exist since GCC 4.5.) For the trunk, committed as Rev.

[Patch, Fortran] PR57785 - Fix folding of dot_product for complex vars

2013-07-03 Thread Tobias Burnus
Pending patches:http://gcc.gnu.org/ml/fortran/2013-07/msg2.html Thanks goes to Dominique for debugging the issue! Build and regtested on x86-64-gnu-linux. OK for the trunk? I think one should also backport it to 4.7/4.8. (Folding - and hence the bug - exist since GCC 4.5.) Tobias

Re: [Patch, Fortran] PR57785 - Fix folding of dot_product for complex vars

2013-07-03 Thread Dominique Dhumieres
Dear Tobias, The patch is OK, but you may consider the following remarks: (1) a comment before + c = gfc_simplify_conjg (a); reminding the definition of the complex dot product. (2) I don't like the scan-tree-dump: they are fragile and have a limited coverage. I'ld prefer a test