Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-18 Thread Steve Kargl
On Wed, Dec 18, 2019 at 08:47:31AM +, Mark Eggleston wrote: > > It is a bit confusing that the Fortran FE source files have the .c > extension implying C when they are C++ and are compiled using C++. It is not puzzling at all. gfortran was added to GCC some 15 years ago. gfortran was origin

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-18 Thread Mark Eggleston
On 17/12/2019 18:04, Janne Blomqvist wrote: On Tue, Dec 17, 2019 at 7:47 PM Steve Kargl wrote: On Tue, Dec 17, 2019 at 05:28:05PM +, Mark Eggleston wrote: On 17/12/2019 17:06, Steve Kargl wrote: On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: gcc/fortran/ChangeLog

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-18 Thread Mark Eggleston
On 17/12/2019 17:47, Steve Kargl wrote: On Tue, Dec 17, 2019 at 05:28:05PM +, Mark Eggleston wrote: On 17/12/2019 17:06, Steve Kargl wrote: On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: gcc/fortran/ChangeLog     Mark Eggleston      PR fortran/92896     * arr

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-17 Thread Steve Kargl
On Tue, Dec 17, 2019 at 08:04:30PM +0200, Janne Blomqvist wrote: > > Well, frontends are nowadays C++, so > > a) No need to include stdbool.h, bool is a builtin type. > > b) optional arguments are a thing (they are also used elsewhere in the > Fortran frontend). > Ah, yes. The creep of C++ in

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-17 Thread Janne Blomqvist
On Tue, Dec 17, 2019 at 7:47 PM Steve Kargl wrote: > > On Tue, Dec 17, 2019 at 05:28:05PM +, Mark Eggleston wrote: > > > > On 17/12/2019 17:06, Steve Kargl wrote: > > > On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: > > >> gcc/fortran/ChangeLog > > >> > > >> Mark Egglest

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-17 Thread Steve Kargl
On Tue, Dec 17, 2019 at 05:28:05PM +, Mark Eggleston wrote: > > On 17/12/2019 17:06, Steve Kargl wrote: > > On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: > >> gcc/fortran/ChangeLog > >> > >>     Mark Eggleston  > >> > >>     PR fortran/92896 > >>     * array.c (walk_ar

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-17 Thread Mark Eggleston
On 17/12/2019 17:06, Steve Kargl wrote: On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: gcc/fortran/ChangeLog     Mark Eggleston      PR fortran/92896     * array.c (walk_array_constructor): Replace call to cfg_convert_type s/cfg_convert_type/gfc_convert_type    

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-17 Thread Steve Kargl
On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: > gcc/fortran/ChangeLog > >     Mark Eggleston  > >     PR fortran/92896 >     * array.c (walk_array_constructor): Replace call to cfg_convert_type s/cfg_convert_type/gfc_convert_type >     with call to gfc_convert_type_warn w

[Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

2019-12-17 Thread Mark Eggleston
Prevent conversion of character data in array constructors. Fix for PR fortran/92896 [10 Regression] [DEC] ICE in reduce_unary, at fortran/arith.c:1283. This was caused by an unintended side affect of "Allow CHARACTER literals in assignments and data statements" (revision 277975). If the con