Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-07 Thread Renlin Li
171.swim fails on aarch64-linux as well. I dis a bisect and confirm it's r248877 causing the miscompare. Regards, Renlin On 06/06/17 12:05, Markus Trippelsdorf wrote: On 2017.06.05 at 22:39 +0200, Nicolas Koenig wrote: With all the style fixes committed as r248877. 171_swim fails now. I did

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-06 Thread Markus Trippelsdorf
On 2017.06.05 at 22:39 +0200, Nicolas Koenig wrote: > With all the style fixes committed as r248877. 171_swim fails now. I didn't bisect, but I suspect your revision. -- Markus

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-05 Thread Nicolas Koenig
With all the style fixes committed as r248877. Thanks for the review. Nicolas On 06/03/2017 06:25 PM, Jerry DeLisle wrote: On 06/03/2017 06:48 AM, Nicolas Koenig wrote: Hello everyone, here is a version of the patch that includes a workaround for PR 80960. I have also included a separate te

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-03 Thread Bernhard Reutner-Fischer
On Sat, Jun 03, 2017 at 09:25:31AM -0700, Jerry DeLisle wrote: > On 06/03/2017 06:48 AM, Nicolas Koenig wrote: > > Hello everyone, > > > > here is a version of the patch that includes a workaround for PR 80960. I > > have > > also included a separate test case for the failure that Dominique detec

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-03 Thread Jerry DeLisle
On 06/03/2017 06:48 AM, Nicolas Koenig wrote: > Hello everyone, > > here is a version of the patch that includes a workaround for PR 80960. I have > also included a separate test case for the failure that Dominique detected. > The > style issues should be fixed. > > Regression-tested. OK for tru

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-03 Thread Nicolas Koenig
Hello everyone, here is a version of the patch that includes a workaround for PR 80960. I have also included a separate test case for the failure that Dominique detected. The style issues should be fixed. Regression-tested. OK for trunk? Nicolas Changelog: 2017-06-03 Nicolas Koenig

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-01 Thread Dominique d'Humières
> Le 1 juin 2017 à 16:19, Dominique d'Humières a écrit : > > I see > > FAIL: gfortran.dg/deferred_character_2.f90 -O1 execution test > FAIL: gfortran.dg/deferred_character_2.f90 -O2 execution test > FAIL: gfortran.dg/deferred_character_2.f90 -O3 -fomit-frame-pointer > -funroll-loops -f

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-01 Thread Dominique d'Humières
> Le 1 juin 2017 à 11:30, Dominique d'Humières a écrit : > > >> Le 31 mai 2017 à 21:03, Nicolas Koenig a écrit : >> >> Hello Dominique, >> >> attached is the next try, this time without stupidities (I hope). Both test >> cases you posted don't ICE anymore. >> >> Ok for trunk? >> >> Nicola

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-01 Thread Dominique d'Humières
> Le 31 mai 2017 à 21:03, Nicolas Koenig a écrit : > > Hello Dominique, > > attached is the next try, this time without stupidities (I hope). Both test > cases you posted don't ICE anymore. > > Ok for trunk? > > Nicolas > Preliminary tests look OK, full testing in progress. Thanks, Domin

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-31 Thread Bernhard Reutner-Fischer
On 31 May 2017 at 21:03, Nicolas Koenig wrote: > Hello Dominique, > > attached is the next try, this time without stupidities (I hope). Both test > cases you posted don't ICE anymore. > > Ok for trunk? Please check contrib/check_GNU_style.sh /tmp/p8.diff and let me point you to contrib/vimrc Fur

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-31 Thread Nicolas Koenig
Hello Dominique, attached is the next try, this time without stupidities (I hope). Both test cases you posted don't ICE anymore. Ok for trunk? Nicolas Regression tested for x86_64-pc-linux-gnu. Changelog (still the same): 2017-05-27 Nicolas Koenig PR fortran/35339 * fron

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-31 Thread Dominique d'Humières
> Le 31 mai 2017 à 17:40, Dominique d'Humières a écrit : > > If I am not mistaken, compiling the following code with the patch applied simpler test print *,(huge(0),i=1,6) ! print*,(i,i=1,6) ! print*,(i,i=1,6,1) end > > gives an ICE. > > TIA > > Dominique

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-31 Thread Dominique d'Humières
If I am not mistaken, compiling the following code with the patch applied program test_ivs use iso_varying_string implicit none type(varying_string),dimension(:,:),allocatable :: array2d type(varying_string) :: extra integer :: i,j allocate(array2d(2,3)) extra = "four" array2d(

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-30 Thread Bernhard Reutner-Fischer
On 29 May 2017 17:49:30 CEST, Nicolas Koenig wrote: >Hello Dominique, > >mea culpa, their was a bit confusion with the file being open in emacs >and vi at the same time. Attached is the new patch with the #define >removed. +static int +simplify_io_impl_do (gfc_code **code, int *walk_subtrees, +

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-29 Thread Dominique d'Humières
> Le 29 mai 2017 à 17:49, Nicolas Koenig a écrit : > > Hello Dominique, > > mea culpa, their was a bit confusion with the file being open in emacs > and vi at the same time. Attached is the new patch with the #define removed. > > Nicolas > Thanks for the quick fix! Testing in progress Domi

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-29 Thread Nicolas Koenig
Hello Dominique, mea culpa, their was a bit confusion with the file being open in emacs and vi at the same time. Attached is the new patch with the #define removed. Nicolas On 05/29/2017 05:32 PM, Dominique d'Humières wrote: Hi Nicolas, Updating gfortran with your patch fails with ../../wor

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-29 Thread Dominique d'Humières
Hi Nicolas, Updating gfortran with your patch fails with ../../work/gcc/fortran/frontend-passes.c: In function 'bool traverse_io_block(gfc_code*, bool*, gfc_code*)': ../../work/gcc/fortran/frontend-passes.c:1067:20: error: expected unqualified-id before '(' token #define swap(x, y) (x) ^= (y),

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-28 Thread Jerry DeLisle
On 05/27/2017 12:49 PM, Nicolas Koenig wrote: Hello everyone, attached is a patch to simplify implied do loops in io statements by replacing them with their respective array slices. For example "WRITE (*,*) (a(i), i=1,4,2)" becomes "WRITE (*,*) a(1:4:2)". Ok for trunk? Thanks for patch. C

[Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-27 Thread Nicolas Koenig
Hello everyone, attached is a patch to simplify implied do loops in io statements by replacing them with their respective array slices. For example "WRITE (*,*) (a(i), i=1,4,2)" becomes "WRITE (*,*) a(1:4:2)". Ok for trunk? Nicolas Regression tested for x85_64-pc-linux-gnu. Changelog: 2017