Re: *ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-16 Thread Paul Richard Thomas
Dear Mikael, With your tweak it bootstrapped and regtested OK. Also changed the comment after Steve's pointing out that the last sentence was incomprehensible:-) Committed to trunk as revision 223234. Cheers Paul 2015-05-16 Mikael Morin mik...@gcc.gnu.org Paul Thomas

Re: *ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-15 Thread Paul Richard Thomas
Dear Mikael, dear all, I am struggling to find time for gfortran at present because of the change in my personal circumstances. I am still working full time as a consultant, whilst trying to sell the house and fix up all those things that l'Administration Francaise makes so interesting (Having

*ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-15 Thread Mikael Morin
Le 09/05/2015 15:12, Mikael Morin a écrit : Le 01/05/2015 20:25, Paul Richard Thomas a écrit : Dear All, By the time I went to commit, something had changed and the patch caused a regression. I presume that the version that I had of Andre's patch was not the same as the one committed. I'll

Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-09 Thread Mikael Morin
Le 01/05/2015 20:25, Paul Richard Thomas a écrit : Dear All, By the time I went to commit, something had changed and the patch caused a regression. I presume that the version that I had of Andre's patch was not the same as the one committed. I'll cast an eye over it this weekend and see if

Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-01 Thread Paul Richard Thomas
Dear All, By the time I went to commit, something had changed and the patch caused a regression. I presume that the version that I had of Andre's patch was not the same as the one committed. I'll cast an eye over it this weekend and see if I can understand what gives. Cheers paul On 27 April

Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-04-27 Thread Paul Richard Thomas
Dear Steve, Thanks for the review. I THINK that I know what I meant in the comment :-) I will commit tomorrow night. Cheers Paul On 26 April 2015 at 20:53, Steve Kargl s...@troutmask.apl.washington.edu wrote: On Sun, Apr 26, 2015 at 08:35:06PM +0200, Paul Richard Thomas wrote: ---

[Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-04-26 Thread Paul Richard Thomas
Dear All, This patch exploits Mikael's identification of the location of the problem and his testcase. It requires Andre's patch for PR59678 as a prerequisite. It is almost certainly a bit over-conservative but it seems to be free of any memory leakage. The ChangeLog and the comments describe it

Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-04-26 Thread Steve Kargl
On Sun, Apr 26, 2015 at 08:35:06PM +0200, Paul Richard Thomas wrote: --- 7062,7091 { if (expr-expr_type != EXPR_STRUCTURE) { + tree dealloc = NULL_TREE; gfc_init_se (se, NULL); gfc_conv_expr (se, expr); gfc_add_block_to_block (block,