Re: [Patch, fortran] PR66681 - Wrong result in assigning this_image() to a complex coarray

2015-09-10 Thread Paul Richard Thomas
Dear FX, I am puzzled by this business of the SAVE_EXPR: First, I agree entirely that it is a mystery as to why the SAVE_EXPR appears. It does not do so for array elements nor for arrays. Secondly, as far as I can tell, SAVE_EXPR_RESOLVED_P(…) merely implies that a pointer to a tree is

Re: [Patch, fortran] PR66681 - Wrong result in assigning this_image() to a complex coarray

2015-09-08 Thread FX
> This is something of a corner case, where gfc_conv_expr comes back > with a SAVE_EXPR, in the case of complex, scalar, coarray lvalues. The > first field of the SAVE_EXPR is a perfectly viable expression to > assign to, so I have taken that. If anybody out there has a better > solution, please

[Patch, fortran] PR66681 - Wrong result in assigning this_image() to a complex coarray

2015-09-07 Thread Paul Richard Thomas
Dear All, This is something of a corner case, where gfc_conv_expr comes back with a SAVE_EXPR, in the case of complex, scalar, coarray lvalues. The first field of the SAVE_EXPR is a perfectly viable expression to assign to, so I have taken that. If anybody out there has a better solution, please