Re: [Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-19 Thread Paul Richard Thomas
Dear Dominique, Committed to trunk as revision 254936. Thanks for picking up the problem and for redoing the testing. Regards Paul

Re: [Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-19 Thread Dominique d'Humières
Looks good to me (as in "pass all my tests"). Thanks, Dominique > Le 18 nov. 2017 à 14:02, Paul Richard Thomas > a écrit : > > Dear Dominique, > > Please find attached a revised patch that I believe fixes the problem > that you found. The changes are the

Re: [Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-18 Thread Paul Richard Thomas
Dear Dominique, Please find attached a revised patch that I believe fixes the problem that you found. The changes are the additions in trans-decl.c. OK for trunk and 7-branch? Paul 2017-11-18 Paul Thomas PR fortran/78990 * expr.c (gfc_is_class_array_function):

Re: [Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-17 Thread Paul Richard Thomas
Hi Dominique, Quite suddenly, I am seeing fault too. I don't know what has changed. I'm on to it. Thanks Paul On 15 November 2017 at 11:40, Dominique d'Humières wrote: > Hi Paul, > > Your patch fixes the ICE and pass the tests. However I see > > At line 22 of file

Re: [Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-15 Thread Dominique d'Humières
Hi Paul, Your patch fixes the ICE and pass the tests. However I see At line 22 of file pr78990.f90 Fortran runtime error: Attempting to allocate already allocated variable ‘return_t1' for the original tests (with mold or source). This runtime error depends on the options: % gfc pr78990.f90 %

[Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-13 Thread Paul Richard Thomas
This turned out to be quite a challenging debugging job as often seems to be the case where the scalarizer is involved. Ultimately, I found that the testcase compiled when return_t1 was made a pointer and the resulting code revealed where the problems lay. This modified testcase now works as well