Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Many thanks, Damian. I will commit soonish; probably tomorrow. Paul On 3 January 2018 at 00:22, Damian Rouson wrote: > I have now confirmed that the patch works the same for the 7 branch: it > doesn’t break any previously passing tests. > > Damian > > On January

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

I have now confirmed that the patch works the same for the 7 branch: it doesn’t break any previously passing tests.   Damian On January 1, 2018 at 9:44:59 AM, Paul Richard Thomas (paul.richard.tho...@gmail.com) wrote: Committed to trunk as revision 256065. Damian, it would be good if you

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Committed to trunk as revision 256065. Damian, it would be good if you would confirm that there are no issues with applying the patch to 7-branch. Thanks for all the help. Paul On 28 December 2017 at 19:58, Damian Rouson wrote: > I applied the patch the trunk and

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

I applied the patch the trunk and confirmed that it doesn’t break any previously passing OpenCoarrays tests.  Is that sufficient or should I also try applying the  patch to the 7 branch? Damian

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi all, as long as the computation where the token can be found is adapted in the same way, i.e. the token's offset in the derived type monitors the changed position, everything is fine. When I remember correctly, then this is done automatically by the routines setting up the caf_ref-chain for

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi All, OK - I'll hold back until I hear from Damian & Zaak. Cheers Paul On 27 December 2017 at 21:06, Damian Rouson wrote: > > Thanks for the additional information Thomas. It sounds like I should test > Paul’s patch. I should be able to do so today and will

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

  Thanks for the additional information Thomas. It sounds like I should test Paul’s patch. I should be able to do so today and will post the results by tomorrow. I’m adding OpenCoarrays developer Zaak Beekman to the cc and attaching the patch again in case he wants to try it as well.  Zaak,

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi Damian, Does breaking binary compatibility simply mean that CAF codes will need to be recompiled (which is fine) Well... not really. We are not supposed to break binary compatibility in a release. For gcc-8, we have greater freedom because we had to do it anyway. Now, the interesting

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

  Hi Paul, Does breaking binary compatibility simply mean that CAF codes will need to be recompiled (which is fine) or does it mean that there will need to be work done on OpenCoarrays to support the changes in this patch (which is unlikely to happen soon without new contributors to

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

It also fixes pr78983 and partially pr80235. Thanks Dominique > Le 27 déc. 2017 à 19:04, Thomas Koenig a écrit : > > Hi Paul, > > by the way, the patch is OK for trunk. It is just gcc-7 that I am > worried about. > > Regards > > Thomas

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi Paul, by the way, the patch is OK for trunk. It is just gcc-7 that I am worried about. Regards Thomas

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi Thomas, That's a good question. I have kept Damian in copy. It must be said that the OpenCoarray folk are more concerned with PR83319, where there is no problem of binary compatibility. I am awaiting some input from him. Cheers Paul On 27 December 2017 at 17:50, Thomas Koenig

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi Paul, It will break binary compatibility for caf with scalar, allocatable/pointer components. This comes about because I decided that the caf tokens for thes components, should come after all other components, rather than immediately after the "owner" component. This has the advantage, that

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi Thomas, It will break binary compatibility for caf with scalar, allocatable/pointer components. This comes about because I decided that the caf tokens for thes components, should come after all other components, rather than immediately after the "owner" component. This has the advantage, that

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi Paul, This is a complete rework of the patch and of the original mechanism for adding caf token fields and finding them. In this patch, the token fields are added to the derived types after all the components have been resolved. This is done so that all the tokens appear at the very end of

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Hi All, This is a complete rework of the patch and of the original mechanism for adding caf token fields and finding them. In this patch, the token fields are added to the derived types after all the components have been resolved. This is done so that all the tokens appear at the very end of the

Re: [Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

Dear Paul, > Bootstrapped and regtested on FC23/x86_64 - OK for trunk? See my comment 7 in the PR. Dominique

[Patch, fortran] PR83076 - [8 Regression] ICE in gfc_deallocate_scalar_with_status, at fortran/trans.c:1598

This problem is not really a regression but is a "feature" that was exposed by my patch for PR81447. The testcase fails because the caf token for the pointer component is not present in the type. This is fixed in trans-types.c (gfc_get_derived_type) in the manner described in the ChangeLog.