Re: [Patch, fortran] PRs 70752 and 72709 - more deferred character length bugs

2018-09-30 Thread Paul Richard Thomas
Dear Dominique and Janne, Putting the problem right turned out to be trivial. In the part of the patch in gfc_conv_array_ref, what was being passed as 'decl' , in the failing test from PR82617 was indeed an indirect reference. Applying one dollop of indirection fixed it. The original testcase

Re: [Patch, fortran] PRs 70752 and 72709 - more deferred character length bugs

2018-09-30 Thread Paul Richard Thomas
Hi Dominique, It's the patch for pr70752 that causes the trouble, which I had guessed from the point in trans.c where the ICE occurs. I am onto it. Thanks again Paul On Wed, 26 Sep 2018 at 16:52, Dominique d'Humières wrote: > > > Is se->string_length guaranteed to be of type

Re: [Patch, fortran] PRs 70752 and 72709 - more deferred character length bugs

2018-09-26 Thread Paul Richard Thomas
Hi Dominique, Thanks for the heads up - I will check it out and fix it next week before doing any commits. Cheers Paul On 26 September 2018 at 16:52, Dominique d'Humières wrote: >> Is se->string_length guaranteed to be of type gfc_array_index_type_here? >> If so, why? And if not, maybe a

Re: [Patch, fortran] PRs 70752 and 72709 - more deferred character length bugs

2018-09-26 Thread Dominique d'Humières
> Is se->string_length guaranteed to be of type gfc_array_index_type_here? > If so, why? And if not, maybe a fold_convert is in order? I don’t know if this related, but if I build gfortran with the patches for PRs 70752 and 72709, 70149, and 65677 with --enable-checking=yes, compiling the test

Re: [Patch, fortran] PRs 70752 and 72709 - more deferred character length bugs

2018-09-25 Thread Janne Blomqvist
On Tue, Sep 25, 2018 at 8:06 PM Paul Richard Thomas < paul.richard.tho...@gmail.com> wrote: > This patch is a bit more complicated than some of the previous posts. > However, the ChangeLog explains the story pretty clearly. > > Bootstraps and regtests on FC21/x86_64 - OK for trunk and 8-branch? >

[Patch, fortran] PRs 70752 and 72709 - more deferred character length bugs

2018-09-25 Thread Paul Richard Thomas
This patch is a bit more complicated than some of the previous posts. However, the ChangeLog explains the story pretty clearly. Bootstraps and regtests on FC21/x86_64 - OK for trunk and 8-branch? Again, better names for the testcases will be determined before committing. Paul 2018-09-25 Paul