Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2015-01-02 Thread Tim Shen
On Fri, Jan 2, 2015 at 8:54 AM, Jonathan Wakely wrote: > That's done now, so please go ahead and commit the fix. Committed. I obviously used wrong branch (which doesn't include the actual change) for testing so I missed the testing failure. Sorry about that. :( -- Regards, Tim Shen

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2015-01-02 Thread Jonathan Wakely
On 2 January 2015 at 16:19, Jonathan Wakely wrote: > On 2 January 2015 at 01:29, Tim Shen wrote: >> Oh, errr... I'm not sure if it needs a review by probably Jonathan? > > I think it qualifies as obvious and so doesn't need approval, but > please wait for me to rotate the ChangeLog file, so we star

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2015-01-02 Thread Jonathan Wakely
On 2 January 2015 at 01:29, Tim Shen wrote: > Oh, errr... I'm not sure if it needs a review by probably Jonathan? I think it qualifies as obvious and so doesn't need approval, but please wait for me to rotate the ChangeLog file, so we start a new file for 2015. I'm going to do that in the next hou

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2015-01-01 Thread Hans-Peter Nilsson
On Thu, 1 Jan 2015, Tim Shen wrote: > On Thu, Jan 1, 2015 at 5:06 PM, Hans-Peter Nilsson wrote: > > But apparently not committed yet (at r219139) for some reason? > > Oh, errr... I'm not sure if it needs a review by probably Jonathan? I thought it was an obvious one-character typo, but I'll not

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2015-01-01 Thread Tim Shen
On Thu, Jan 1, 2015 at 5:06 PM, Hans-Peter Nilsson wrote: > But apparently not committed yet (at r219139) for some reason? Oh, errr... I'm not sure if it needs a review by probably Jonathan? -- Regards, Tim Shen

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2015-01-01 Thread Hans-Peter Nilsson
On Wed, 31 Dec 2014, Tim Shen wrote: > On Wed, Dec 31, 2014 at 4:17 PM, David Edelsohn wrote: > > FAIL: 28_regex/algorithms/regex_match/ecma/char/backref.cc execution test > > > > on AIX. > > Oops, a dumb mistake from fixing a dumb mistake. Thanks David! :) > > Bootstrapped and tested. But appar

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2014-12-31 Thread Tim Shen
On Wed, Dec 31, 2014 at 4:17 PM, David Edelsohn wrote: > FAIL: 28_regex/algorithms/regex_match/ecma/char/backref.cc execution test > > on AIX. Oops, a dumb mistake from fixing a dumb mistake. Thanks David! :) Bootstrapped and tested. -- Regards, Tim Shen commit adee3fe36298ddd79ec04a1e8c3ccac

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2014-12-31 Thread David Edelsohn
After this patch I now see FAIL: 28_regex/algorithms/regex_match/ecma/char/backref.cc execution test on AIX. Thanks, David

Re: [Patch, libstdc++/64441] Fix sub_match::first and second

2014-12-31 Thread Jonathan Wakely
OK - thanks On 31 December 2014 at 06:58, Tim Shen wrote: > A dumb mistake :) > > Bootstrapped and tested. > > Thanks! > > -- > Regards, > Tim Shen

[Patch, libstdc++/64441] Fix sub_match::first and second

2014-12-30 Thread Tim Shen
A dumb mistake :) Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit 7fc4b45bb9cf6b1c6ec6620092ae18fe41cb57af Author: timshen Date: Tue Dec 30 21:14:48 2014 -0800 2014-12-30 Tim Shen PR libstdc++/64441 * include/bits/regex.tcc (__regex_algo_impl): s/auto/auto&/