Hello Richard:
On 19/06/24 3:26 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>> On 19/06/24 2:52 pm, Richard Sandiford wrote:
>>> Ajit Agarwal writes:
On 19/06/24 2:40 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>> Hello Richard:
>>
>> On 19/06/24 1:54 pm,
Ajit Agarwal writes:
> On 19/06/24 2:52 pm, Richard Sandiford wrote:
>> Ajit Agarwal writes:
>>> On 19/06/24 2:40 pm, Richard Sandiford wrote:
Ajit Agarwal writes:
> Hello Richard:
>
> On 19/06/24 1:54 pm, Richard Sandiford wrote:
>> Ajit Agarwal writes:
What
Hello Richard:
On 19/06/24 2:52 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>> On 19/06/24 2:40 pm, Richard Sandiford wrote:
>>> Ajit Agarwal writes:
Hello Richard:
On 19/06/24 1:54 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>>> What happens if you leave
Ajit Agarwal writes:
> On 19/06/24 2:40 pm, Richard Sandiford wrote:
>> Ajit Agarwal writes:
>>> Hello Richard:
>>>
>>> On 19/06/24 1:54 pm, Richard Sandiford wrote:
Ajit Agarwal writes:
>> What happens if you leave the assert alone? When does it fire? Is it
>> still for uses in
Hello Richard:
On 19/06/24 2:40 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>> Hello Richard:
>>
>> On 19/06/24 1:54 pm, Richard Sandiford wrote:
>>> Ajit Agarwal writes:
> What happens if you leave the assert alone? When does it fire? Is it
> still for uses in debug insns?
Ajit Agarwal writes:
> Hello Richard:
>
> On 19/06/24 1:54 pm, Richard Sandiford wrote:
>> Ajit Agarwal writes:
What happens if you leave the assert alone? When does it fire? Is it
still for uses in debug insns? If so, it's the fusion pass's
responsibility
to update
Hello Richard:
On 19/06/24 1:54 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>>> What happens if you leave the assert alone? When does it fire? Is it
>>> still for uses in debug insns? If so, it's the fusion pass's responsibility
>>> to update those, as mentioned above. And it must
Ajit Agarwal writes:
>> What happens if you leave the assert alone? When does it fire? Is it
>> still for uses in debug insns? If so, it's the fusion pass's responsibility
>> to update those, as mentioned above. And it must update them before,
>> or at the same time as, it deletes the
Hello Richard:
On 19/06/24 12:52 pm, Ajit Agarwal wrote:
> Hello Richard:
>
> On 19/06/24 2:01 am, Richard Sandiford wrote:
>> Ajit Agarwal writes:
>>> Hello Richard:
>>>
>>> On 14/06/24 4:26 pm, Richard Sandiford wrote:
Ajit Agarwal writes:
> Hello Richard:
>
> All comments
Hello Richard:
On 19/06/24 2:01 am, Richard Sandiford wrote:
> Ajit Agarwal writes:
>> Hello Richard:
>>
>> On 14/06/24 4:26 pm, Richard Sandiford wrote:
>>> Ajit Agarwal writes:
Hello Richard:
All comments are addressed.
>>>
>>> I don't think this addresses the following
Ajit Agarwal writes:
> Hello Richard:
>
> On 14/06/24 4:26 pm, Richard Sandiford wrote:
>> Ajit Agarwal writes:
>>> Hello Richard:
>>>
>>> All comments are addressed.
>>
>> I don't think this addresses the following comments from the previous
>> reviews:
>>
>> (1) It is not correct to mark
Hello Richard:
On 14/06/24 4:26 pm, Richard Sandiford wrote:
> Ajit Agarwal writes:
>> Hello Richard:
>>
>> All comments are addressed.
>
> I don't think this addresses the following comments from the previous
> reviews:
>
> (1) It is not correct to mark existing insn uses as live-out.
>
Ajit Agarwal writes:
> Hello Richard:
>
> All comments are addressed.
I don't think this addresses the following comments from the previous
reviews:
(1) It is not correct to mark existing insn uses as live-out.
The patch mustn't try to do this.
(2) To quote a previous review:
It's
13 matches
Mail list logo