Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-20 Thread Ajit Agarwal
Hello Richard: On 19/06/24 3:26 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >> On 19/06/24 2:52 pm, Richard Sandiford wrote: >>> Ajit Agarwal writes: On 19/06/24 2:40 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >> Hello Richard: >> >> On 19/06/24 1:54 pm,

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Richard Sandiford
Ajit Agarwal writes: > On 19/06/24 2:52 pm, Richard Sandiford wrote: >> Ajit Agarwal writes: >>> On 19/06/24 2:40 pm, Richard Sandiford wrote: Ajit Agarwal writes: > Hello Richard: > > On 19/06/24 1:54 pm, Richard Sandiford wrote: >> Ajit Agarwal writes: What

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Ajit Agarwal
Hello Richard: On 19/06/24 2:52 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >> On 19/06/24 2:40 pm, Richard Sandiford wrote: >>> Ajit Agarwal writes: Hello Richard: On 19/06/24 1:54 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >>> What happens if you leave

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Richard Sandiford
Ajit Agarwal writes: > On 19/06/24 2:40 pm, Richard Sandiford wrote: >> Ajit Agarwal writes: >>> Hello Richard: >>> >>> On 19/06/24 1:54 pm, Richard Sandiford wrote: Ajit Agarwal writes: >> What happens if you leave the assert alone? When does it fire? Is it >> still for uses in

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Ajit Agarwal
Hello Richard: On 19/06/24 2:40 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >> Hello Richard: >> >> On 19/06/24 1:54 pm, Richard Sandiford wrote: >>> Ajit Agarwal writes: > What happens if you leave the assert alone? When does it fire? Is it > still for uses in debug insns?

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Richard Sandiford
Ajit Agarwal writes: > Hello Richard: > > On 19/06/24 1:54 pm, Richard Sandiford wrote: >> Ajit Agarwal writes: What happens if you leave the assert alone? When does it fire? Is it still for uses in debug insns? If so, it's the fusion pass's responsibility to update

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Ajit Agarwal
Hello Richard: On 19/06/24 1:54 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >>> What happens if you leave the assert alone? When does it fire? Is it >>> still for uses in debug insns? If so, it's the fusion pass's responsibility >>> to update those, as mentioned above. And it must

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Richard Sandiford
Ajit Agarwal writes: >> What happens if you leave the assert alone? When does it fire? Is it >> still for uses in debug insns? If so, it's the fusion pass's responsibility >> to update those, as mentioned above. And it must update them before, >> or at the same time as, it deletes the

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Ajit Agarwal
Hello Richard: On 19/06/24 12:52 pm, Ajit Agarwal wrote: > Hello Richard: > > On 19/06/24 2:01 am, Richard Sandiford wrote: >> Ajit Agarwal writes: >>> Hello Richard: >>> >>> On 14/06/24 4:26 pm, Richard Sandiford wrote: Ajit Agarwal writes: > Hello Richard: > > All comments

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-19 Thread Ajit Agarwal
Hello Richard: On 19/06/24 2:01 am, Richard Sandiford wrote: > Ajit Agarwal writes: >> Hello Richard: >> >> On 14/06/24 4:26 pm, Richard Sandiford wrote: >>> Ajit Agarwal writes: Hello Richard: All comments are addressed. >>> >>> I don't think this addresses the following

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-18 Thread Richard Sandiford
Ajit Agarwal writes: > Hello Richard: > > On 14/06/24 4:26 pm, Richard Sandiford wrote: >> Ajit Agarwal writes: >>> Hello Richard: >>> >>> All comments are addressed. >> >> I don't think this addresses the following comments from the previous >> reviews: >> >> (1) It is not correct to mark

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-18 Thread Ajit Agarwal
Hello Richard: On 14/06/24 4:26 pm, Richard Sandiford wrote: > Ajit Agarwal writes: >> Hello Richard: >> >> All comments are addressed. > > I don't think this addresses the following comments from the previous > reviews: > > (1) It is not correct to mark existing insn uses as live-out. >

Re: [Patch, rs6000, middle-end] v2: Add implementation for different targets for pair mem fusion

2024-06-14 Thread Richard Sandiford
Ajit Agarwal writes: > Hello Richard: > > All comments are addressed. I don't think this addresses the following comments from the previous reviews: (1) It is not correct to mark existing insn uses as live-out. The patch mustn't try to do this. (2) To quote a previous review: It's