RE: [Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-14 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay > Sent: Tuesday, February 14, 2012 10:52 AM > To: Weddington, Eric > Cc: gcc-patches@gcc.gnu.org; Denis Chertykov > Subject: Re: [Patch,AVR]: Built-in for non-contiguous port layouts > > Weddington, Eric wrote: >

Re: [Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-14 Thread Georg-Johann Lay
Weddington, Eric wrote: > >> >> This patch set removes __builtin_avr_map8 __builtin_avr_map16 >> built-ins and implements a built-in __builtin_avr_insert_bits instead. >> > > In your avr_fold_builtin function you have switch (fcode) with only one > case (and a "default" that just breaks). Are you

RE: [Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-14 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay > Sent: Monday, February 13, 2012 9:01 AM > To: gcc-patches@gcc.gnu.org > Cc: Weddington, Eric; Denis Chertykov > Subject: [Patch,AVR]: Built-in for non-contiguous port layouts > > This patch set re

[Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-13 Thread Georg-Johann Lay
This patch set removes __builtin_avr_map8 __builtin_avr_map16 built-ins and implements a built-in __builtin_avr_insert_bits instead. This has several reasons: * From user feedback I learned that speed matters more than size here * I found that the new built-in has better usability and fits bette