Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-31 Thread Joerg Wunsch
As Georg-Johann Lay wrote: > So here is the next version of the patch, returning to printf again > :-) "works for me" -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/NIC: JW11-RIPE Never trust an operating system you don't hav

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-31 Thread Richard Henderson
On 05/31/2012 03:47 AM, Georg-Johann Lay wrote: * config/avr/t-avr: Correct avr-mmcu.texi dependencies. (s-avr-mmcu-texi): Don't sed on gen-avr-mmcu-texi output. * config/avr/gen-avr-mmcu-texi.c: Sort MCUs. * doc/avr-mmcu.texi: Regenerate. Ok. Thanks for your pa

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-31 Thread Georg-Johann Lay
Joerg Wunsch wrote: > As Georg-Johann Lay wrote: > >> If it's appropriate I would also set svn:mime-type to something >> like application/foo but that seems bit odd. > > Rather set the svn:eol-style attribute to "LF" instead, I'd say. > > But wait a moment, why not setting the svn:eol-style to "

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-31 Thread Joerg Wunsch
As Georg-Johann Lay wrote: > If it's appropriate I would also set svn:mime-type to something > like application/foo but that seems bit odd. Rather set the svn:eol-style attribute to "LF" instead, I'd say. But wait a moment, why not setting the svn:eol-style to "native", and the generator utility

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-31 Thread Georg-Johann Lay
Richard Henderson wrote: >> +# The avr-mmcu.texi we want to compare against / check into svn should >> +# have unix-style line endings. To make this work on MinGW, remove \r. >> +# \r is not portable to Solaris tr, therefore we have a special case >> +# for ASCII. We use \r for other encodings l

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-30 Thread Pedro Alves
On 05/30/2012 10:26 PM, Pedro Alves wrote: > On 05/30/2012 05:44 PM, Joerg Wunsch wrote: > >> As Richard Henderson wrote: >> >>> Instead of writing to stdout, open the file to write, and open >>> it in binary mode. Seems much easier than fighting with conversion >>> after the fact. >> >> (Discla

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-30 Thread Pedro Alves
On 05/30/2012 05:44 PM, Joerg Wunsch wrote: > As Richard Henderson wrote: > >> Instead of writing to stdout, open the file to write, and open >> it in binary mode. Seems much easier than fighting with conversion >> after the fact. > > (Disclaimer: I'm not the author.) > > There has been an arg

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-30 Thread Joerg Wunsch
As Richard Henderson wrote: > Instead of writing to stdout, open the file to write, and open > it in binary mode. Seems much easier than fighting with conversion > after the fact. (Disclaimer: I'm not the author.) There has been an argument that (some) older implementations might not be able to

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-30 Thread Richard Henderson
On 05/30/2012 05:17 AM, Georg-Johann Lay wrote: +# The avr-mmcu.texi we want to compare against / check into svn should +# have unix-style line endings. To make this work on MinGW, remove \r. +# \r is not portable to Solaris tr, therefore we have a special case +# for ASCII. We use \r for other

Re: [Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-30 Thread Joerg Wunsch
As Georg-Johann Lay wrote: > The problem was reported by Joerg. Does it work for you? Yes, it works fine. > + case `echo X|tr X '\101'` in\ > + A) tr -d '\015' < tmp-avr-mmcu.texi > tmp2-avr-mmcu.texi ;; \ > + *) tr -d '\r' < tmp-avr-mmcu.tex

[Patch,AVR]: Use tr instead of set to canonicalize line endings for cmp

2012-05-30 Thread Georg-Johann Lay
This patch replaces sed with tr when t-avr checks for consistency between generated doc/avr-mmcu.texi and the compiler. The method is the same as used in s-tm-texi in gcc/Makefile.in The problem was reported by Joerg. Does it work for you? Ok for trunk? Johann * config/avr/t-avr: Corre