Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-22 Thread James Greenhalgh
On Fri, Feb 22, 2019 at 09:39:59AM -0600, Matthew Malcomson wrote: > Hi James, > > On 22/02/19 00:09, James Greenhalgh wrote: > > On Mon, Feb 18, 2019 at 08:40:12AM -0600, Matthew Malcomson wrote: > >> > >> Additionally, this patch contains two tidy-ups (happy to remove them or > >> put in > >>

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-22 Thread Matthew Malcomson
Hi James, On 22/02/19 00:09, James Greenhalgh wrote: > On Mon, Feb 18, 2019 at 08:40:12AM -0600, Matthew Malcomson wrote: >> >> Additionally, this patch contains two tidy-ups (happy to remove them or put >> in >> a separate patch if people want): > > Generally, yes I prefer that. > I've

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-21 Thread Mike Stump
On Feb 21, 2019, at 4:09 PM, James Greenhalgh wrote: > >> NOTE: I have included a bunch of RTL testcases that I used in development, >> these >> don't exercise much of the compiler and are pretty specific to the backend >> as it >> currently is, so I'm not sure they give much value. I'd

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-21 Thread James Greenhalgh
On Mon, Feb 18, 2019 at 08:40:12AM -0600, Matthew Malcomson wrote: > Handle stack pointer with SUBS/ADDS instructions. > > In general the stack pointer was not handled for many SUBS/ADDS patterns in > aarch64.md. > Both the "extended register" and "immediate" forms allow the stack pointer to >

[Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-18 Thread Matthew Malcomson
Handle stack pointer with SUBS/ADDS instructions. In general the stack pointer was not handled for many SUBS/ADDS patterns in aarch64.md. Both the "extended register" and "immediate" forms allow the stack pointer to be used as the source register, while no form allows the stack pointer for the