Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-08-09 Thread Joseph Myers
On Fri, 22 Jun 2018, Steve Ellcey wrote: > I can see both sides of this and don't feel strongly one way or the > other.  I have attached a new patch that does allow for the use of just > -l options to force the linker to be called. I don't think this patch achieves the desired semantics. My

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-06-22 Thread Steve Ellcey
On Tue, 2018-06-19 at 15:22 +, Joseph Myers wrote: >  > > What should plain > >   gcc -Wl,-rpath=/foo > > do?  Whatever it should do regarding trying to link or not trying to link, > it should do the same if you also name a header on the command line to be > compiled to a precompiled

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-06-19 Thread Joseph Myers
On Tue, 19 Jun 2018, Steve Ellcey wrote: > The problem with this is that num_linker_inputs isn't getting > incremented when it sees a file to be turned into a precompiled header > it gets incremented when it sees a linker flag like '-rpath'. > > The comments in driver::prepare_infiles make it

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-06-19 Thread Steve Ellcey
On Fri, 2018-06-08 at 11:17 +, Joseph Myers wrote: > On Wed, 2 May 2018, Steve Ellcey wrote: > > > > > I tracked this down to driver::maybe_run_linker where it sees the linker > > flags and increments num_linker_inputs, this causes the routine to call > > the linker.   This patch checks to

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-06-08 Thread Joseph Myers
On Wed, 2 May 2018, Steve Ellcey wrote: > I tracked this down to driver::maybe_run_linker where it sees the linker > flags and increments num_linker_inputs, this causes the routine to call > the linker.   This patch checks to see if we are creating precompiled > header files and avoids calling

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-06-04 Thread Steve Ellcey
Ping^2 Steve Ellcey sell...@cavium.com On Thu, 2018-05-17 at 14:50 -0700, Steve Ellcey wrote: > Ping. > > Steve Ellcey > sell...@cavium.com > > > On Wed, 2018-05-02 at 12:47 -0700, Steve Ellcey wrote: > > > > This is a new version of a patch I sent out last year to stop gcc from > > trying

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-05-17 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Wed, 2018-05-02 at 12:47 -0700, Steve Ellcey wrote: > This is a new version of a patch I sent out last year to stop gcc from > trying to do a link when creating precompiled headers and a linker > flag is also given. > > When I build and test GCC I also

[Patch] Do not call the linker if we are creating precompiled header files

2018-05-02 Thread Steve Ellcey
This is a new version of a patch I sent out last year to stop gcc from trying to do a link when creating precompiled headers and a linker flag is also given. When I build and test GCC I also build glibc and then I run the GCC tests with -Wl,-rpath and -Wl,--dynamic-linker so that I don't have to