Re: [Patch] OpenACC: Fix reduction tree-sharing issue [PR106982]

2022-09-26 Thread Thomas Schwinge
Hi! On 2022-09-26T11:34:48+0200, Richard Biener via Gcc-patches wrote: > On Mon, Sep 26, 2022 at 11:27 AM Tobias Burnus > wrote: >> On 26.09.22 10:32, Richard Biener wrote: >>> On Fri, Sep 23, 2022 at 5:25 PM Tobias Burnus >>> wrote: >> >>> This fixes a tree-sharing ICE. Thanks for looking

Re: [Patch] OpenACC: Fix reduction tree-sharing issue [PR106982]

2022-09-26 Thread Richard Biener via Gcc-patches
On Mon, Sep 26, 2022 at 11:27 AM Tobias Burnus wrote: > > Hi Richard, > > On 26.09.22 10:32, Richard Biener wrote: > > On Fri, Sep 23, 2022 at 5:25 PM Tobias Burnus wrote: > > This fixes a tree-sharing ICE. It seems as if all unshare_expr > I added were required in this case. [...] > > looks

Re: [Patch] OpenACC: Fix reduction tree-sharing issue [PR106982]

2022-09-26 Thread Tobias Burnus
Hi Richard, On 26.09.22 10:32, Richard Biener wrote: On Fri, Sep 23, 2022 at 5:25 PM Tobias Burnus wrote: This fixes a tree-sharing ICE. It seems as if all unshare_expr I added were required in this case. [...] looks like v1/v2/v3 are now unshared twice

Re: [Patch] OpenACC: Fix reduction tree-sharing issue [PR106982]

2022-09-26 Thread Richard Biener via Gcc-patches
On Fri, Sep 23, 2022 at 5:25 PM Tobias Burnus wrote: > > This fixes a tree-sharing ICE. It seems as if all unshare_expr > I added were required in this case. The first long testcase is > based on the real testcase from the OpenACC testsuite, the second > one is what reduction produced - but I

[Patch] OpenACC: Fix reduction tree-sharing issue [PR106982]

2022-09-23 Thread Tobias Burnus
This fixes a tree-sharing ICE. It seems as if all unshare_expr I added were required in this case. The first long testcase is based on the real testcase from the OpenACC testsuite, the second one is what reduction produced - but I thought some nested reduction might be interesting as well; hence,