Re: [Patch] OpenMP: Ignore side-effects when finding struct comps [PR108545]

2023-03-01 Thread Tobias Burnus
On 01.03.23 14:03, Jakub Jelinek wrote: On Tue, Feb 28, 2023 at 02:06:43PM +0100, Tobias Burnus wrote: [...] Do we use that hashing even say for ARRAY_REFs with array indexes? Using OEP_MATCH_SIDE_EFFECTS will mean that volatile int idx; a.b[idx] and a.b[idx] will compare equal. On the other sid

Re: [Patch] OpenMP: Ignore side-effects when finding struct comps [PR108545]

2023-03-01 Thread Jakub Jelinek via Gcc-patches
On Tue, Feb 28, 2023 at 02:06:43PM +0100, Tobias Burnus wrote: > (This is marked as P1 regression) > > Since the structure handling updates, a hash is now used to find expressions > which are identical; > unfortunately, this mishandles 'volatile' vars as expressions involving them > are not rega

[Patch] OpenMP: Ignore side-effects when finding struct comps [PR108545]

2023-02-28 Thread Tobias Burnus
(This is marked as P1 regression) Since the structure handling updates, a hash is now used to find expressions which are identical; unfortunately, this mishandles 'volatile' vars as expressions involving them are not regarded as identical. This leads to spurious *multiple* 'map(struct:x' that l