Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Ralf Wildenhues
Hello, * Tristan Gingold wrote on Mon, May 16, 2011 at 03:20:19PM CEST: > Ok for trunk ? FWIW this looks good to me, and certainly necessary for Posix and portable sed, but I can't approve it. Thanks, Ralf > fixincludes/ > 2011-05-16 Tristan Gingold > > * inclhack.def (solaris_complex

Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Tristan Gingold
On May 16, 2011, at 5:45 PM, Bruce Korb wrote: > Hi Tristan, > > On Mon, May 16, 2011 at 8:27 AM, Tristan Gingold wrote: >> Yes, it is ok on GNU/Linux and Solaris. >> >> Do I really need to test on HP/UX and AIX ? Won't be easy for me. > > Solaris and BSD are usually the most unusual, so I'd

Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Bruce Korb
Hi Tristan, On Mon, May 16, 2011 at 8:27 AM, Tristan Gingold wrote: > Yes, it is ok on GNU/Linux and Solaris. > > Do I really need to test on HP/UX and AIX ?  Won't be easy for me. Solaris and BSD are usually the most unusual, so I'd say go ahead for mainline and see if you get squawks. With se

Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Tristan Gingold
On May 16, 2011, at 3:40 PM, Bruce Korb wrote: > Hi Tristan, > > On Mon, May 16, 2011 at 6:20 AM, Tristan Gingold wrote: >> Hi, >> >> this rule (and only this one) uses the c function of sed. According to man, >> the syntax should be: >> >> [2addr]c\ >> text >> >> (Note the trailin

Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Bruce Korb
Hi Tristan, On Mon, May 16, 2011 at 6:20 AM, Tristan Gingold wrote: > Hi, > > this rule (and only this one) uses the c function of sed.  According to man, > the syntax should be: > >     [2addr]c\ >     text > > (Note the trailing back-slash). > But as currently written, there is no backslash in

[Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Tristan Gingold
Hi, this rule (and only this one) uses the c function of sed. According to man, the syntax should be: [2addr]c\ text (Note the trailing back-slash). But as currently written, there is no backslash in it. As a consequence 'make check' fails at least on Darwin (BSD derived sed comman