Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-06 Thread Tim Shen
On Tue, Dec 6, 2016 at 6:37 AM, Jonathan Wakely wrote: > On 06/12/16 12:49 +, Jonathan Wakely wrote: >> >> On 06/12/16 03:52 -0800, Tim Shen wrote: >>> >>> On Tue, Dec 6, 2016 at 2:30 AM, Jonathan Wakely wrote: This looks good - OK for trunk, thanks! >>> >>> >>>

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-06 Thread Jonathan Wakely
On 06/12/16 12:49 +, Jonathan Wakely wrote: On 06/12/16 03:52 -0800, Tim Shen wrote: On Tue, Dec 6, 2016 at 2:30 AM, Jonathan Wakely wrote: This looks good - OK for trunk, thanks! Committed. Thanks! ChangeLog dates fixed by this patch. And pretty printer fixed by this one. The

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-06 Thread Jonathan Wakely
On 06/12/16 03:52 -0800, Tim Shen wrote: On Tue, Dec 6, 2016 at 2:30 AM, Jonathan Wakely wrote: This looks good - OK for trunk, thanks! Committed. Thanks! ChangeLog dates fixed by this patch. commit c3651cf0403b826414b8376bb29b4757530f4eec Author: redi

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-06 Thread Tim Shen
On Tue, Dec 6, 2016 at 2:30 AM, Jonathan Wakely wrote: > This looks good - OK for trunk, thanks! Committed. Thanks! -- Regards, Tim Shen

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-06 Thread Jonathan Wakely
On 02/12/16 19:14 -0800, Tim Shen wrote: On Wed, Nov 30, 2016 at 8:27 AM, Jonathan Wakely wrote: On 26/11/16 21:38 -0800, Tim Shen wrote: This 4-patch series contains the following in order: a.diff: Remove uses-allocator ctors. They are going away, and removing it reduces the maintenance

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-02 Thread Tim Shen
On Wed, Nov 30, 2016 at 8:27 AM, Jonathan Wakely wrote: > On 26/11/16 21:38 -0800, Tim Shen wrote: >> >> This 4-patch series contains the following in order: >> >> a.diff: Remove uses-allocator ctors. They are going away, and removing >> it reduces the maintenance burden from now on. > > > Yay!

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-12-01 Thread Jonathan Wakely
On 30/11/16 19:29 -0800, Tim Shen wrote: On Wed, Nov 30, 2016 at 8:27 AM, Jonathan Wakely wrote: On 26/11/16 21:38 -0800, Tim Shen wrote: + template> struct _Uninitialized; I'm still unsure that is_literal_type is the right trait here. If it's definitely right then we should probably

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-11-30 Thread Tim Shen
On Wed, Nov 30, 2016 at 8:27 AM, Jonathan Wakely wrote: > On 26/11/16 21:38 -0800, Tim Shen wrote: >> + template> >> struct _Uninitialized; > > > I'm still unsure that is_literal_type is the right trait here. If it's > definitely right then we should probably *not* deprecate it in C++17! No

Re: [Patches] Add variant constexpr support for visit, comparisons and get

2016-11-30 Thread Jonathan Wakely
On 26/11/16 21:38 -0800, Tim Shen wrote: This 4-patch series contains the following in order: a.diff: Remove uses-allocator ctors. They are going away, and removing it reduces the maintenance burden from now on. Yay! less code. b.diff: Add constexpr support for get<> and comparisons. This

[Patches] Add variant constexpr support for visit, comparisons and get

2016-11-26 Thread Tim Shen
This 4-patch series contains the following in order: a.diff: Remove uses-allocator ctors. They are going away, and removing it reduces the maintenance burden from now on. b.diff: Add constexpr support for get<> and comparisons. This patch also involves small refactoring of _Variant_storage.