Re: [RFA][PATCH] Refactor duplicated code used by various dom walkers

2017-11-03 Thread Jeff Law
On 11/03/2017 09:01 AM, Jeff Law wrote: On 11/03/2017 04:05 AM, Richard Biener wrote: On Fri, Nov 3, 2017 at 4:49 AM, Jeff Law wrote: Several passes which perform dominator walks want to identify when block has a single incoming edge, ignoring loop backedges. I'm aware of 4 implementatio

Re: [RFA][PATCH] Refactor duplicated code used by various dom walkers

2017-11-03 Thread Jeff Law
On 11/03/2017 04:05 AM, Richard Biener wrote: On Fri, Nov 3, 2017 at 4:49 AM, Jeff Law wrote: Several passes which perform dominator walks want to identify when block has a single incoming edge, ignoring loop backedges. I'm aware of 4 implementations of this code. 3 of the 4 are identical

Re: [RFA][PATCH] Refactor duplicated code used by various dom walkers

2017-11-03 Thread Richard Biener
On Fri, Nov 3, 2017 at 4:49 AM, Jeff Law wrote: > > > > Several passes which perform dominator walks want to identify when block has > a single incoming edge, ignoring loop backedges. > > I'm aware of 4 implementations of this code. 3 of the 4 are identical in > function. The 4th (tree-ssa-dom.c

[RFA][PATCH] Refactor duplicated code used by various dom walkers

2017-11-02 Thread Jeff Law
Several passes which perform dominator walks want to identify when block has a single incoming edge, ignoring loop backedges. I'm aware of 4 implementations of this code. 3 of the 4 are identical in function. The 4th (tree-ssa-dom.c) has an additional twist that it also ignores edges tha