Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-02 Thread Uros Bizjak
On Thu, Mar 2, 2017 at 11:31 PM, Jakub Jelinek wrote: > Hi! > > On Wed, Mar 01, 2017 at 08:26:36PM +0100, Uros Bizjak wrote: >> 2017-03-01 Uros Bizjak >> >> * config/i386/i386.c (print_reg): Warn for values of >> unsupported size in integer register. >> >> testsuite/ChangeLog: >> >> 201

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-02 Thread Jakub Jelinek
Hi! On Wed, Mar 01, 2017 at 08:26:36PM +0100, Uros Bizjak wrote: > 2017-03-01 Uros Bizjak > > * config/i386/i386.c (print_reg): Warn for values of > unsupported size in integer register. > > testsuite/ChangeLog: > > 2017-03-01 Uros Bizjak > > * gcc.target/i386/invsize-2.c: Ne

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-01 Thread Uros Bizjak
On Wed, Mar 1, 2017 at 11:41 AM, Uros Bizjak wrote: > On Wed, Mar 1, 2017 at 10:00 AM, Uros Bizjak wrote: >> On Wed, Mar 1, 2017 at 9:48 AM, Jakub Jelinek wrote: >>> On Wed, Mar 01, 2017 at 09:34:53AM +0100, Uros Bizjak wrote: Some more thoughts on 64-bit reg on 32-bit targets warning.

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-01 Thread Uros Bizjak
On Wed, Mar 1, 2017 at 10:00 AM, Uros Bizjak wrote: > On Wed, Mar 1, 2017 at 9:48 AM, Jakub Jelinek wrote: >> On Wed, Mar 01, 2017 at 09:34:53AM +0100, Uros Bizjak wrote: >>> Some more thoughts on 64-bit reg on 32-bit targets warning. >>> >>> Actually, we never *print* register name for instructi

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-01 Thread Uros Bizjak
On Wed, Mar 1, 2017 at 9:48 AM, Jakub Jelinek wrote: > On Wed, Mar 01, 2017 at 09:34:53AM +0100, Uros Bizjak wrote: >> Some more thoughts on 64-bit reg on 32-bit targets warning. >> >> Actually, we never *print* register name for instruction that use "A" >> constraint, since %eax/%edx is always im

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-01 Thread Jakub Jelinek
On Wed, Mar 01, 2017 at 09:34:53AM +0100, Uros Bizjak wrote: > Some more thoughts on 64-bit reg on 32-bit targets warning. > > Actually, we never *print* register name for instruction that use "A" > constraint, since %eax/%edx is always implicit The warning does not > deal with constraints, so un

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-03-01 Thread Uros Bizjak
On Tue, Feb 28, 2017 at 4:34 PM, Uros Bizjak wrote: > On Tue, Feb 28, 2017 at 12:06 PM, Jakub Jelinek wrote: >> On Tue, Feb 28, 2017 at 11:41:56AM +0100, Richard Biener wrote: >>> > 2017-02-28 Uros Bizjak >>> > >>> > * config/i386/i386.c (print_reg): Warn for values of 64-bit size >>> >

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-02-28 Thread Jakub Jelinek
On Tue, Feb 28, 2017 at 04:34:20PM +0100, Uros Bizjak wrote: > > Have you tried to build say Linux kernel or firefox or similar large > > codebase with lots of inline asm with that? > > No... > > > What constraint should people use for long long vars in 32-bit code? > > "A" constraint is used a l

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-02-28 Thread Uros Bizjak
On Tue, Feb 28, 2017 at 12:06 PM, Jakub Jelinek wrote: > On Tue, Feb 28, 2017 at 11:41:56AM +0100, Richard Biener wrote: >> > 2017-02-28 Uros Bizjak >> > >> > * config/i386/i386.c (print_reg): Warn for values of 64-bit size >> > in integer register on 32-bit targets. Error out for valu

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-02-28 Thread Jakub Jelinek
On Tue, Feb 28, 2017 at 11:41:56AM +0100, Richard Biener wrote: > > 2017-02-28 Uros Bizjak > > > > * config/i386/i386.c (print_reg): Warn for values of 64-bit size > > in integer register on 32-bit targets. Error out for values of > > 8-bit size in invalid integer register. > > >

Re: [RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-02-28 Thread Richard Biener
On Tue, 28 Feb 2017, Uros Bizjak wrote: > Hello! > > Attached patch: > > a) warns for 64-bit values in GR asm operand on 32bit targets > > It is impossible to pass 64-bit (long long) value in 32bit register. > We should warn for this situation, since only 32bit lowpart value is > passed. The wa

[RFA PATCH, i386]: Warn for 64-bit values in general-reg asm operands and error out for 8-bit values in invalid GR asm operand

2017-02-28 Thread Uros Bizjak
Hello! Attached patch: a) warns for 64-bit values in GR asm operand on 32bit targets It is impossible to pass 64-bit (long long) value in 32bit register. We should warn for this situation, since only 32bit lowpart value is passed. The warning can be omitted by explicitly casting asm operand to i