Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-15 Thread Tom de Vries
On 06/15/2018 05:33 PM, Andreas Schwab wrote: > On Jun 15 2018, Tom de Vries wrote: > >> Where do you see the duplication? > > The problem is actually that dg-final.exp is run multiple times, once > for every parallel execution of the testsuite. Ah, I see. Thanks for noting that. This patch

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-15 Thread Andreas Schwab
On Jun 15 2018, Tom de Vries wrote: > Where do you see the duplication? The problem is actually that dg-final.exp is run multiple times, once for every parallel execution of the testsuite. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-15 Thread Tom de Vries
On 06/15/2018 05:05 PM, Andreas Schwab wrote: > On Jun 12 2018, Tom de Vries wrote: > >> I've made the PASS/FAIL id minimal (removed the actual args part), which >> makes >> it easier to read: >> ... >> PASS: scan-tree-dump: too many arguments >> PASS: scan-tree-dump: too few arguments >>

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-15 Thread Andreas Schwab
On Jun 12 2018, Tom de Vries wrote: > I've made the PASS/FAIL id minimal (removed the actual args part), which makes > it easier to read: > ... > PASS: scan-tree-dump: too many arguments > PASS: scan-tree-dump: too few arguments > PASS: scan-tree-dump-times: too many arguments > PASS:

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-12 Thread Tom de Vries
On Mon, Jun 11, 2018 at 04:00:39PM -0600, Jeff Law wrote: > On 05/30/2018 04:41 AM, Tom de Vries wrote: > > Hi, > > > > this patch tests the error behaviour of dg-final directives when called > > with an > > incorrect number of arguments. > > > > The test is lazy, in that it doesn't bother to

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-11 Thread Jeff Law
On 05/30/2018 04:41 AM, Tom de Vries wrote: > Hi, > > this patch tests the error behaviour of dg-final directives when called with > an > incorrect number of arguments. > > The test is lazy, in that it doesn't bother to pass correct arguments, > assuming > that the number of arguments check is

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-05-31 Thread Mike Stump
On May 30, 2018, at 3:41 AM, Tom de Vries wrote: > > this patch tests the error behaviour of dg-final directives when called with > an > incorrect number of arguments. Seems reasonable. Unless someone wanted to argue against it for some reason (not portable, takes too much time, hard to

[RFC] Add gcc.dg-selftests/dg-final.exp

2018-05-30 Thread Tom de Vries
Hi, this patch tests the error behaviour of dg-final directives when called with an incorrect number of arguments. The test is lazy, in that it doesn't bother to pass correct arguments, assuming that the number of arguments check is done before checking the actual arguments. Using the patch, I