Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-05-17 Thread Richard Biener
On Fri, 14 May 2021, Xionghu Luo wrote: > Hi Richi, > > On 2021/4/21 19:54, Richard Biener wrote: > > On Tue, 20 Apr 2021, Xionghu Luo wrote: > > > >> > >> > >> On 2021/4/15 19:34, Richard Biener wrote: > >>> On Thu, 15 Apr 2021, Xionghu Luo wrote: > >>> > Thanks, > > On

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-05-14 Thread Xionghu Luo via Gcc-patches
Hi Richi, On 2021/4/21 19:54, Richard Biener wrote: > On Tue, 20 Apr 2021, Xionghu Luo wrote: > >> >> >> On 2021/4/15 19:34, Richard Biener wrote: >>> On Thu, 15 Apr 2021, Xionghu Luo wrote: >>> Thanks, On 2021/4/14 14:41, Richard Biener wrote: >> "#538,#235,#234,#233" will

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-04-23 Thread Jeff Law via Gcc-patches
On 4/14/2021 12:41 AM, Richard Biener wrote: On Wed, 14 Apr 2021, Xionghu Luo wrote: Hi, On 2021/3/26 15:35, Xionghu Luo via Gcc-patches wrote: Also we already have a sinking pass on RTL which even computes a proper PRE on the reverse graph - -fgcse-sm aka store-motion.c. I'm not sure

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-04-21 Thread Richard Biener
On Tue, 20 Apr 2021, Xionghu Luo wrote: > > > On 2021/4/15 19:34, Richard Biener wrote: > > On Thu, 15 Apr 2021, Xionghu Luo wrote: > > > >> Thanks, > >> > >> On 2021/4/14 14:41, Richard Biener wrote: > "#538,#235,#234,#233" will all be sunk from bb 35 to bb 37 by rtl-sink, > but it

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-04-15 Thread Richard Biener
On Thu, 15 Apr 2021, Xionghu Luo wrote: > Thanks, > > On 2021/4/14 14:41, Richard Biener wrote: > >> "#538,#235,#234,#233" will all be sunk from bb 35 to bb 37 by rtl-sink, > >> but it moves #538 first, then #235, there is strong dependency here. It > >> seemsdoesn't like the LCM framework that

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-04-15 Thread Xionghu Luo via Gcc-patches
Thanks, On 2021/4/14 14:41, Richard Biener wrote: >> "#538,#235,#234,#233" will all be sunk from bb 35 to bb 37 by rtl-sink, >> but it moves #538 first, then #235, there is strong dependency here. It >> seemsdoesn't like the LCM framework that could solve all and do the >> delete-insert in one

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-04-14 Thread Richard Biener
On Wed, 14 Apr 2021, Xionghu Luo wrote: > Hi, > > On 2021/3/26 15:35, Xionghu Luo via Gcc-patches wrote: > >> Also we already have a sinking pass on RTL which even computes > >> a proper PRE on the reverse graph - -fgcse-sm aka store-motion.c. > >> I'm not sure whether this deals with non-stores

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-04-13 Thread Xionghu Luo via Gcc-patches
Hi, On 2021/3/26 15:35, Xionghu Luo via Gcc-patches wrote: >> Also we already have a sinking pass on RTL which even computes >> a proper PRE on the reverse graph - -fgcse-sm aka store-motion.c. >> I'm not sure whether this deals with non-stores but the >> LCM machinery definitely can handle

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-03-26 Thread Xionghu Luo via Gcc-patches
Hi, sorry for late response, On 2021/3/23 16:50, Richard Biener wrote: >>> It definitely should be before uncprop (but context stops there). And yes, >>> re-running passes isn't the very, very best thing to do without explaining >>> it cannot be done in other ways. Not for late stage 3 anyway.

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-03-23 Thread Richard Biener
On Tue, 23 Mar 2021, Xionghu Luo wrote: > > > On 2020/12/23 00:53, Richard Biener wrote: > > On December 21, 2020 10:03:43 AM GMT+01:00, Xiong Hu Luo > > wrote: > >> Here comes another case that requires run a pass once more, as this is > >> not the common suggested direction to solve

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2021-03-22 Thread Xionghu Luo via Gcc-patches
On 2020/12/23 00:53, Richard Biener wrote: On December 21, 2020 10:03:43 AM GMT+01:00, Xiong Hu Luo wrote: Here comes another case that requires run a pass once more, as this is not the common suggested direction to solve problems, not quite sure whether it is still a reasonble fix here.

Re: [RFC] Run pass_sink_code once more after ivopts/fre

2020-12-22 Thread Richard Biener
On December 21, 2020 10:03:43 AM GMT+01:00, Xiong Hu Luo wrote: >Here comes another case that requires run a pass once more, as this is >not the common suggested direction to solve problems, not quite sure >whether it is still a reasonble fix here. Source code is something >like: > >ref = ip +

[RFC] Run pass_sink_code once more after ivopts/fre

2020-12-21 Thread Xiong Hu Luo via Gcc-patches
Here comes another case that requires run a pass once more, as this is not the common suggested direction to solve problems, not quite sure whether it is still a reasonble fix here. Source code is something like: ref = ip + *hslot; while (ip < in_end - 2) { unsigned int len = 2; len++;