Tobias Burnus writes:
> 2014-12-06 Tobias Burnus
> Manuel L³pez-Ib¡±ez
>
> gcc/
> * diagnostic.c (get_terminal_width): Renamed from getenv_columns,
> removed static, and additionally use ioctl to get width.
> (diagnostic_set_caret_max_width): Update call.
>
Hi all,
I have now updated the patch, based on all comments and Manuel's patch.
And bootstrapped it on x86-64-gnu-linux. If there are no more comments,
I intent to commit it tomorrow. If it gets approved earlier, I will
commit it earlier ;-)
Some comments from me are below.
FX wrote:
So th
> So the patch you (Manual) are proposing looks fine to me, with the
> environment variable taking precedence, *if* that is fine for Fortran,
> of course.
That seems fine to me, from the Fortran standpoint. COLUMNS is a bit of a
special environment variable, which the shell (when it provides it)
Manuel López-Ibáñez writes:
[...]
> On 10 December 2014 at 12:10, Dodji Seketeli wrote:
[...]
>> Manuel, was there a particular reason to avoid mentioning the COLUMNS
>> environment variable in the documentation?
>
> Not that I remember. Perhaps the documentation should say something
> like:
On 10 December 2014 at 12:10, Dodji Seketeli wrote:
>>
>> Note that -fmessage-length= applies to the error message (wraps) _and_
>> the caret diagnostic (truncates) while the COLUMNS variable _only_
>> applies to the caret diagnostic. (BTW: The documentation currently
>> does not mention COLUMNS.)
Hello Tobias,
Thank you for this patch. I have a few comments about it below. Just
as a heads-up, I am asking questions to Manuel in there, as well as
referring to comments from FX's. Please read below.
Tobias Burnus writes:
> This patch fixes a Fortran diagnostic "regression".
>
> With the
OK. But if we rename the function, why not simply terminal_width() ?
FX
> Le 6 déc. 2014 à 23:14, Tobias Burnus a écrit :
>
> This patch fixes a Fortran diagnostic "regression".
>
> With the current common diagnostic, the width shown with caret diagnostic is
> determined by:
>
>case OP
This patch fixes a Fortran diagnostic "regression".
With the current common diagnostic, the width shown with caret
diagnostic is determined by:
case OPT_fmessage_length_:
pp_set_line_maximum_length (dc->printer, value);
diagnostic_set_caret_max_width (dc, value);
plus
diagno
