Re: [asan] Protection of globals

2012-10-17 Thread Diego Novillo
On 2012-10-17 07:11 , Jakub Jelinek wrote: 2012-10-17 Jakub Jelinek * varasm.c: Include asan.h. (assemble_noswitch_variable): Grow size by asan_red_zone_size if decl is asan protected. (place_block_symbol): Likewise. (assemble_variable): If decl is asa

Re: [asan] Protection of globals

2012-10-17 Thread Xinliang David Li
Yes, I think it is good for the branch. thanks, David On Wed, Oct 17, 2012 at 4:11 AM, Jakub Jelinek wrote: > On Tue, Oct 16, 2012 at 02:41:42PM -0700, Xinliang David Li wrote: >> On Tue, Oct 16, 2012 at 7:58 AM, Jakub Jelinek wrote: >> Why the above two condition? If the linker picks the larg

[asan] Protection of globals

2012-10-17 Thread Jakub Jelinek
On Tue, Oct 16, 2012 at 02:41:42PM -0700, Xinliang David Li wrote: > On Tue, Oct 16, 2012 at 7:58 AM, Jakub Jelinek wrote: > Why the above two condition? If the linker picks the larger size one, > it is ok to do the instrumentation. Added more comments, creation of local aliases when needed, and