Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-06-08 Thread Jason Merrill
On 06/08/2011 05:29 AM, Rainer Orth wrote: Once I got around to it, this proved to be remarkably easy, as can be seen below. Yes, much better. The dwarf2asm change is OK. Jason

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-06-08 Thread Mike Stump
On Jun 8, 2011, at 2:29 AM, Rainer Orth wrote: > Bootstrapped without regressions on i386-apple-darwin9.8.0. > powerpc-apple-darwin9.8.0 bootstrap is still running. Unfortunately, > Darwin seems to be exceedingly unreliable under load: tests randomly > time out and work again the next time. This

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-06-08 Thread Mike Stump
On Jun 8, 2011, at 2:29 AM, Rainer Orth wrote: > The Darwin parts of the previous versions have already been approved, > but I'd appreciate if Mike could have a look at the changes. Ok for > mainline? Ok.

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-06-08 Thread IainS
On 8 Jun 2011, at 10:29, Rainer Orth wrote: Darwin seems to be exceedingly unreliable under load: tests randomly time out and work again the next time. If you mean random timeouts in dejagnu - I suspect (but have not yet proved) that the culprit is insufficient stack allocation in some co

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-06-08 Thread Rainer Orth
Jason Merrill writes: > On 05/19/2011 01:33 PM, Rainer Orth wrote: >> The cleanest way to account for this seems to allow overriding >> USE_LINKONCE_INDIRECT in target headers (darwin.h in this case). >> >> If Jason or Richard consider this appropriate, I'll modify the patch >> accordingly and ap

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-05-19 Thread Jason Merrill
On 05/19/2011 01:33 PM, Rainer Orth wrote: The cleanest way to account for this seems to allow overriding USE_LINKONCE_INDIRECT in target headers (darwin.h in this case). If Jason or Richard consider this appropriate, I'll modify the patch accordingly and apply after retesting. Not really. Th

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-05-19 Thread Rainer Orth
Mike Stump writes: > On May 4, 2011, at 5:08 AM, Rainer Orth wrote: >> The following patch is a prerequisite for making >> >> [lto, testsuite] Don't use visibility on targets that don't support it >> (PR lto/47334) >>http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00295.html > >> -# d

Re: [build] Define HAVE_GAS_HIDDEN on Darwin

2011-05-09 Thread Mike Stump
On May 4, 2011, at 5:08 AM, Rainer Orth wrote: > The following patch is a prerequisite for making > > [lto, testsuite] Don't use visibility on targets that don't support it > (PR lto/47334) >http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00295.html > -# define USE_LINKONCE_INDIRECT (

[build] Define HAVE_GAS_HIDDEN on Darwin

2011-05-04 Thread Rainer Orth
The following patch is a prerequisite for making [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334) http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00295.html work on Darwin by defining HAVE_GAS_HIDDEN on that target, too. Instead of special-casin