Re: [c++-concepts] requires expressions

2013-07-27 Thread Andrew Sutton
Committed. On Fri, Jul 26, 2013 at 10:27 PM, Gabriel Dos Reis wrote: > Andrew Sutton writes: > > | Fixed and committed, but I have a small follow-up related to parameter > | packs in requires clauses. The checking for unexpanded parameter packs > | treats the parameter declarations like regular

Re: [c++-concepts] requires expressions

2013-07-26 Thread Gabriel Dos Reis
Andrew Sutton writes: | Fixed and committed, but I have a small follow-up related to parameter | packs in requires clauses. The checking for unexpanded parameter packs | treats the parameter declarations like regular PARM_DECL references | and gives errors that they are unexpanded packs. | | 201

Re: [c++-concepts] requires expressions

2013-07-26 Thread Jason Merrill
Makes sense. Jason

Re: [c++-concepts] requires expressions

2013-07-26 Thread Andrew Sutton
Fixed and committed, but I have a small follow-up related to parameter packs in requires clauses. The checking for unexpanded parameter packs treats the parameter declarations like regular PARM_DECL references and gives errors that they are unexpanded packs. 2013-07-26 Andrew Sutton * gcc/c

Re: [c++-concepts] requires expressions

2013-07-25 Thread Jason Merrill
On 07/25/2013 10:19 AM, Andrew Sutton wrote: + pp_cxx_parameter_declaration_clause(pp, TREE_OPERAND (t, 0)); Space before (. Otherwise, looks good. Jason

Re: [c++-concepts] requires expressions

2013-07-13 Thread Jason Merrill
On 07/13/2013 05:37 AM, Andrew Sutton wrote: There are two instantiations on purpose. OK. A lot of the new code in pt.c doesn't seem like it needs to be there; let's put as much in constraint.cc as we can. Let's move some of the bits out of semantics.c as well. I think the [fixup|declare]_

Re: [c++-concepts] requires expressions

2013-07-13 Thread Andrew Sutton
> This should be merged with pp_cxx_parameter_declaration_clause. > >> +reqparms_to_string (tree p) > > > And this should have a more generic name. I called this parms_to_string for symmetry with args_to_string. It calls pp_cxx_parameter_declaration_clause. >> + if (check_requirements (t, args)

Re: [c++-concepts] requires expressions

2013-07-12 Thread Jason Merrill
On 07/11/2013 02:59 PM, Andrew Sutton wrote: pp_cxx_requirement_parameter_list (cxx_pretty_printer *pp, tree t) This should be merged with pp_cxx_parameter_declaration_clause. +reqparms_to_string (tree p) And this should have a more generic name. + // requries clause. "requires" +

[c++-concepts] requires expressions

2013-07-11 Thread Andrew Sutton
The attached patch finishes the semantics for requires expressions. It includes reduction rules for constraint decomposition, substitution rules, and diagnostics. Andrew Changelog: 2013-07-11 Andrew Sutton * gcc/cp/cp-tree.h (declare_local_parms): New * gcc/cp/cp-tree.h (fini