[ was: Re: [PATCH, 1/6] Simplify constraint handling ]
On 31/10/15 09:19, Tom de Vries wrote:
On 30/10/15 10:33, Richard Biener wrote:
Yes, but as I said we should refactor things to avoid calling
> >the intra constraints generation from the IPA path.
>
>Ah, I see.
>
>So, like this? OK for trunk if bootstrap and reg-test succeeds?
Yes, like this. But you miss to apply the same to the static chain,
and the varargs "rest".
Ok with that change.
Updated patch, bootstrapped and reg-tested on x86_64.
Committed to trunk as attached.
And now that we don't call intra_create_variable_infos anymore during
ipa_pta_execute, we can simplify intra_create_variable_infos a bit.
Bootstrapped and reg-tested on x86_64.
Committed to trunk as trivial.
Thanks,
- Tom
Don't expect existing varinfo for arguments in intra_create_variable_infos
2015-10-30 Tom de Vries <t...@codesourcery.com>
* tree-ssa-structalias.c (intra_create_variable_infos): Don't expect
existing varinfo for arguments.
---
gcc/tree-ssa-structalias.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c
index b361096..d409727 100644
--- a/gcc/tree-ssa-structalias.c
+++ b/gcc/tree-ssa-structalias.c
@@ -5925,12 +5925,8 @@ intra_create_variable_infos (struct function *fn)
bool recursive_restrict_p
= (restrict_pointer_p
&& !type_contains_placeholder_p (TREE_TYPE (TREE_TYPE (t))));
- varinfo_t p = lookup_vi_for_tree (t);
- if (p == NULL)
- {
- p = create_variable_info_for_1 (t, alias_get_name (t), false);
- insert_vi_for_tree (t, p);
- }
+ varinfo_t p = create_variable_info_for_1 (t, alias_get_name (t), false);
+ insert_vi_for_tree (t, p);
/* For restrict qualified pointers build a representative for
the pointed-to object. Note that this ends up handling
--
1.9.1