[ was: Re: [committed, gomp4] Fix release_dangling_ssa_names ]
On 05/08/15 13:13, Richard Biener wrote:
I think that the whole dance of actually moving things instead of
> >just copying it isn't worth the extra maintainance (well, if we already
> >have a machinery duplicating a SESE region to another function - I
> >suppose gimple_duplicate_sese_region could be trivially changed to
> >support that).
> >
>
>I'll mention that as todo. For now, I think the fastest way to get a working
>version is to fix move_sese_region_to_fn.
Sure.
This patch adds the todo discussed above in the function header comment
of move_sese_region_to_fn.
Committed as obvious.
Thanks,
- Tom
Add todo comment for move_sese_region_to_fn
2015-08-11 Tom de Vries <t...@codesourcery.com>
* tree-cfg.c (move_sese_region_to_fn): Add todo comment.
---
gcc/tree-cfg.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c
index e26454a..588ab69 100644
--- a/gcc/tree-cfg.c
+++ b/gcc/tree-cfg.c
@@ -7011,7 +7011,11 @@ verify_sese (basic_block entry, basic_block exit, vec<basic_block> *bbs_p)
All local variables referenced in the region are assumed to be in
the corresponding BLOCK_VARS and unexpanded variable lists
- associated with DEST_CFUN. */
+ associated with DEST_CFUN.
+
+ TODO: investigate whether we can reuse gimple_duplicate_sese_region to
+ reimplement move_sese_region_to_fn by duplicating the region rather than
+ moving it. */
basic_block
move_sese_region_to_fn (struct function *dest_cfun, basic_block entry_bb,
--
1.9.1
