Il 20/03/2012 11:33, Paolo Carlini ha scritto:
> On 03/20/2012 10:22 AM, Paolo Bonzini wrote:
>> I think \$$ is better. Besides that it looks good.
> Thanks for the review. Yesterday, when Benjamin had a look, I decided to
> go ahead and just commit the patch as posted (after having double
> check
On 03/20/2012 10:22 AM, Paolo Bonzini wrote:
I think \$$ is better. Besides that it looks good.
Thanks for the review. Yesterday, when Benjamin had a look, I decided to
go ahead and just commit the patch as posted (after having double
checked that indeed it worked for me), thus no escaping. Bu
Il 19/03/2012 13:32, Paolo Carlini ha scritto:
Should the addition be \$$ to escape it for the shell as well as for
make?
(I know it works, but that might not be true for all shells.)
>>> i don't think that $, could be expaneded by any shell.
>> I'm not worried about it not expanding
On 03/16/2012 06:16 PM, Jonathan Wakely wrote:
2012/3/16 Paweł Sikora:
Should the addition be \$$ to escape it for the shell as well as for make?
(I know it works, but that might not be true for all shells.)
i don't think that $, could be expaneded by any shell.
I'm not worried about it not ex
2012/3/16 Paweł Sikora:
>> Should the addition be \$$ to escape it for the shell as well as for make?
>> (I know it works, but that might not be true for all shells.)
>
> i don't think that $, could be expaneded by any shell.
I'm not worried about it not expanding, but rather being rejected as
inv
On Friday 16 of March 2012 14:29:21 Jonathan Wakely wrote:
> 2012/3/16 Paweł Sikora:
> > Hi,
> >
> > during gcc build process there's some sed magic
> > (libstdc++-v3/include/Makefile.{am,in}) in action
> > which modifies libstdc++/include/bits/c++config.h (replaces '#define
> > _GLIBCXX_EXTERN_T
On 03/16/2012 03:29 PM, Jonathan Wakely wrote:
Apart from that the patch looks good, I've CC'd gcc-patches, could you
provide a changelog entry?
If this kind of change to the makefile turns out to be applied I think
should go essentially everywhere, at least 4.6 and 4.7(.1) besides mainline.
P
2012/3/16 Paweł Sikora:
> Hi,
>
> during gcc build process there's some sed magic
> (libstdc++-v3/include/Makefile.{am,in}) in action
> which modifies libstdc++/include/bits/c++config.h (replaces '#define
> _GLIBCXX_EXTERN_TEMPLATE'
> according to --enable-extern-template=yes/no settings). in fac
