Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-17 Thread Dominik Vogt
On Sat, Nov 15, 2014 at 07:46:40AM -0800, Ian Taylor wrote: > On Thu, Nov 13, 2014 at 2:58 AM, Dominik Vogt wrote: > > What do you think about the attached patches? They work for me, but I'm > > not sure whether the patch to go-test.exp is good because I know > > nothing about tcl. > > Looks pla

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-15 Thread Ian Taylor
On Thu, Nov 13, 2014 at 2:58 AM, Dominik Vogt wrote: > > What do you think about the attached patches? They work for me, but I'm > not sure whether the patch to go-test.exp is good because I know > nothing about tcl. Looks plausible to me. Ian

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-13 Thread Dominik Vogt
On Fri, Nov 07, 2014 at 08:24:15AM -0800, Ian Taylor wrote: > On Fri, Nov 7, 2014 at 12:51 AM, Dominik Vogt wrote: > > On Thu, Nov 06, 2014 at 09:06:18AM -0800, Ian Taylor wrote: > >> On Thu, Nov 6, 2014 at 4:04 AM, Dominik Vogt > >> wrote: > >> > On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Ta

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-10 Thread Ian Taylor
On Mon, Nov 10, 2014 at 6:00 AM, Dominik Vogt wrote: >> I'd still like to avoid the rampant duplication if possible. One >> approach would be to put most of the test in something like >> nilptr_tests.go marked with "// skip". Then we can have top-level >> nilptrXX.go tests with +build lines that

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-10 Thread Dominik Vogt
> I'd still like to avoid the rampant duplication if possible. One > approach would be to put most of the test in something like > nilptr_tests.go marked with "// skip". Then we can have top-level > nilptrXX.go tests with +build lines that use "// run nilptr_tests.go". I fail to see how that cou

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-09 Thread Michael Hudson-Doyle
Ian Taylor writes: > I don't know what's up with the complex number change. In general the > Go compiler and libraries go to some effort to produce the same > answers on all platforms. We need to understand why we get different > answers on s390 (you may understand the differences, but I don't)

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-07 Thread Ian Taylor
On Fri, Nov 7, 2014 at 12:51 AM, Dominik Vogt wrote: > On Thu, Nov 06, 2014 at 09:06:18AM -0800, Ian Taylor wrote: >> On Thu, Nov 6, 2014 at 4:04 AM, Dominik Vogt wrote: >> > On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: >> >> The way to do it is not by >> >> copying the test. If t

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-07 Thread Dominik Vogt
On Thu, Nov 06, 2014 at 09:06:18AM -0800, Ian Taylor wrote: > On Thu, Nov 6, 2014 at 4:04 AM, Dominik Vogt wrote: > > On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: > >> The way to do it is not by > >> copying the test. If the test needs to be customized, add additional > >> files th

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-06 Thread Ian Taylor
On Thu, Nov 6, 2014 at 4:04 AM, Dominik Vogt wrote: > On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: >> The way to do it is not by >> copying the test. If the test needs to be customized, add additional >> files that use // +build lines to pick which files is built. Move >> them int

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-06 Thread Dominik Vogt
On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: > The way to do it is not by > copying the test. If the test needs to be customized, add additional > files that use // +build lines to pick which files is built. Move > them into a directory, like method4.go or other tests that use > "r

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-05 Thread Ian Taylor
On Wed, Nov 5, 2014 at 2:05 AM, Dominik Vogt wrote: > On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: >> I committed the change to go-test.exp. Thanks. >> >> The other changes are not OK. As described in >> gcc/testsuite/go.test/test/README.gcc, the files in >> gcc/testsuite/go.test/

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-05 Thread Dominik Vogt
On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: > I committed the change to go-test.exp. Thanks. > > The other changes are not OK. As described in > gcc/testsuite/go.test/test/README.gcc, the files in > gcc/testsuite/go.test/test are an exact copy of the master Go > testsuite. Any c

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
I committed the change to go-test.exp. Thanks. The other changes are not OK. As described in gcc/testsuite/go.test/test/README.gcc, the files in gcc/testsuite/go.test/test are an exact copy of the master Go testsuite. Any changes must be made to the master Go testsuite first. I don't know what