Re: [gomp4] Redesign oacc_parallel launch API

2015-08-06 Thread Cesar Philippidis
On 07/28/2015 09:52 AM, Nathan Sidwell wrote: I've committed this patch to the gomp4 branch to redo the launch API. I'll post a version for trunk once the versioning patch gets approved committed. This changes the API in a number of ways, allowing device-specific knowledge to be moved

Re: [gomp4] Redesign oacc_parallel launch API

2015-08-06 Thread Nathan Sidwell
On 08/06/15 18:33, Cesar Philippidis wrote: Looking at set_oacc_fn_attrib, it appears that const values are also considered dynamic. See the attached test case more more info. Is that the expected behavior? If not, I could take a look at this after I finished my reduction patch. It's annoying

Re: [gomp4] Redesign oacc_parallel launch API

2015-07-30 Thread Nathan Sidwell
On 07/29/15 17:45, Nathan Sidwell wrote: On 07/29/15 08:24, Nathan Sidwell wrote: On 07/29/15 05:22, Thomas Schwinge wrote: Likewise for the other torture testing flags. Investigating ... (I've seen those failures be intermittent) Interestingly the fails go away with an unoptimized

Re: [gomp4] Redesign oacc_parallel launch API

2015-07-30 Thread Thomas Schwinge
Hi Nathan! On Wed, 29 Jul 2015 17:45:32 -0400, Nathan Sidwell nat...@acm.org wrote: On 07/29/15 08:24, Nathan Sidwell wrote: On 07/29/15 05:22, Thomas Schwinge wrote: Likewise for the other torture testing flags. Investigating ... (I've seen those failures be intermittent) (For me,

Re: [gomp4] Redesign oacc_parallel launch API

2015-07-29 Thread Nathan Sidwell
On 07/29/15 08:24, Nathan Sidwell wrote: On 07/29/15 05:22, Thomas Schwinge wrote: Likewise for the other torture testing flags. Investigating ... (I've seen those failures be intermittent) Interestingly the fails go away with an unoptimized libgomp. I've observed something vaguely

Re: [gomp4] Redesign oacc_parallel launch API

2015-07-29 Thread Thomas Schwinge
Hi Nathan! On Tue, 28 Jul 2015 12:52:02 -0400, Nathan Sidwell nat...@acm.org wrote: I've committed this patch to the gomp4 branch to redo the launch API. I'll post a version for trunk once the versioning patch gets approved committed. Thanks! (I have not yet looked at the patch in

Re: [gomp4] Redesign oacc_parallel launch API

2015-07-29 Thread Nathan Sidwell
On 07/29/15 05:22, Thomas Schwinge wrote: Hi Nathan! On Tue, 28 Jul 2015 12:52:02 -0400, Nathan Sidwell nat...@acm.org wrote: I've committed this patch to the gomp4 branch to redo the launch API. I'll post a version for trunk once the versioning patch gets approved committed. Thanks! (I

[gomp4] Redesign oacc_parallel launch API

2015-07-28 Thread Nathan Sidwell
I've committed this patch to the gomp4 branch to redo the launch API. I'll post a version for trunk once the versioning patch gets approved committed. This changes the API in a number of ways, allowing device-specific knowledge to be moved into the device compiler and out of the host

Re: [gomp4] Redesign oacc_parallel launch API

2015-07-28 Thread Nathan Sidwell
Oh, one more thing. I placed constants for the 3 launch dimensions into gomp-constants.h, as they are needed by both library and compiler. Working on a patch to remove the current set of constants from omp-low.h nathan