Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-11-23 Thread Thomas Schwinge
Hi Jakub! On Fri, 17 Jul 2015 15:05:59 +0200, Jakub Jelinek wrote: > [...] "omp declare target link" [...] > This patch only marks them with the new attribute, [...] > --- gcc/c/c-parser.c.jj 2015-07-16 18:09:25.0 +0200 > +++ gcc/c/c-parser.c 2015-07-17

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-11-23 Thread Jakub Jelinek
On Mon, Nov 23, 2015 at 12:31:24PM +0100, Thomas Schwinge wrote: > Hi Jakub! > > On Fri, 17 Jul 2015 15:05:59 +0200, Jakub Jelinek wrote: > > [...] "omp declare target link" [...] > > > This patch only marks them with the new attribute, [...] > > > --- gcc/c/c-parser.c.jj

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-11-02 Thread Jakub Jelinek
On Mon, Nov 02, 2015 at 07:54:17PM +0300, Ilya Verbin wrote: > Here is the patch. > make check RUNTESTFLAGS=gomp.exp and check-target-libgomp passed. > OK for gomp-4_5-branch? > > > gcc/c/ > * c-parser.c: Include context.h. > (c_parser_omp_declare_target): If decl has "omp declare

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-11-02 Thread Ilya Verbin
On Fri, Oct 30, 2015 at 20:12:25 +0100, Jakub Jelinek wrote: > On Fri, Oct 30, 2015 at 08:44:07PM +0300, Ilya Verbin wrote: > > On Wed, Oct 28, 2015 at 00:11:03 +0300, Ilya Verbin wrote: > > > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > > > As the testcases show, #pragma omp

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-30 Thread Jakub Jelinek
On Fri, Oct 30, 2015 at 08:44:07PM +0300, Ilya Verbin wrote: > On Wed, Oct 28, 2015 at 00:11:03 +0300, Ilya Verbin wrote: > > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > > As the testcases show, #pragma omp declare target has now a new form > > > (well, > > > two; with some

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-30 Thread Ilya Verbin
On Wed, Oct 28, 2015 at 00:11:03 +0300, Ilya Verbin wrote: > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > As the testcases show, #pragma omp declare target has now a new form (well, > > two; with some issues on it pending), where it is used just as a single > > declarative

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-27 Thread Ilya Verbin
On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > As the testcases show, #pragma omp declare target has now a new form (well, > two; with some issues on it pending), where it is used just as a single > declarative directive rather than a pair of them and allows marking > vars and

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Jakub Jelinek
On Mon, Oct 26, 2015 at 09:35:52PM +0300, Ilya Verbin wrote: > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > As the testcases show, #pragma omp declare target has now a new form (well, > > two; with some issues on it pending), where it is used just as a single > > declarative

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Jakub Jelinek
On Mon, Oct 26, 2015 at 10:39:04PM +0300, Ilya Verbin wrote: > > Without declare target link or to, you can't use the global variables > > in orphaned accelerated routines (unless you e.g. take the address of the > > mapped variable in the region and pass it around). > > The to variables

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Ilya Verbin
On Mon, Oct 26, 2015 at 20:05:39 +0100, Jakub Jelinek wrote: > On Mon, Oct 26, 2015 at 09:35:52PM +0300, Ilya Verbin wrote: > > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > > As the testcases show, #pragma omp declare target has now a new form > > > (well, > > > two; with some

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Ilya Verbin
On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > As the testcases show, #pragma omp declare target has now a new form (well, > two; with some issues on it pending), where it is used just as a single > declarative directive rather than a pair of them and allows marking > vars and

[gomp4.1] Handle new form of #pragma omp declare target

2015-07-17 Thread Jakub Jelinek
Hi! As the testcases show, #pragma omp declare target has now a new form (well, two; with some issues on it pending), where it is used just as a single declarative directive rather than a pair of them and allows marking vars and functions by name as omp declare target vars/functions (which the

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-07-17 Thread James Norris
Jakub, On 07/17/2015 08:05 AM, Jakub Jelinek wrote: Hi! ... I believe OpenACC has something similar, but no idea if it is already implemented. Yes, it is implemented in gomp-4_0-branch. While the purpose for 'omp declare target' and 'acc declare' are similar, the data movement, via the