Re: [google][gcc-4_9] Remove unused key field in gcov_fn_info

else { gfi_ptr = gi_ptr->functions[f_ix]; - if (gfi_ptr && gfi_ptr->key == gi_ptr) + if (gfi_ptr) length = GCOV_TAG_FUNCTION_LENGTH; - else -length = 0; } The removal of 'else' path seems wrong. David On

[google][gcc-4_9] Remove unused key field in gcov_fn_info

Hi, This patch is for google/gcc-4_9 branch. The 'key' field in gcov_fn_info is designed to allow gcov function data to be COMDATTed, but the comdat elimination never works. This patch removes this field to reduce the instrumented object size. Thanks, -Rong Removed the unused 'key' field in

Re: [google][gcc-4_9] Remove unused key field in gcov_fn_info

ok. David On Tue, Sep 29, 2015 at 4:08 PM, Rong Xu wrote: > You are right. I attached the updated patch to this email. > > On Tue, Sep 29, 2015 at 3:10 PM, Xinliang David Li wrote: >>else >> { >>gfi_ptr =

Re: [google][gcc-4_9] Remove unused key field in gcov_fn_info

You are right. I attached the updated patch to this email. On Tue, Sep 29, 2015 at 3:10 PM, Xinliang David Li wrote: >else > { >gfi_ptr = gi_ptr->functions[f_ix]; > - if (gfi_ptr && gfi_ptr->key == gi_ptr) > + if (gfi_ptr) >