Re: [google] Enhance Annotalysis to support cloned functions/methods (issue4591066)

2011-06-13 Thread Diego Novillo
On Mon, Jun 13, 2011 at 12:44, wrote: >> could >>  2149      be optimized away.  */ >>  2150   if (TREE_CODE (TREE_TYPE (DECL_ORIGIN (fdecl))) == METHOD_TYPE >>  2151       && gimple_call_num_args(call) > 0) > >> Wouldn't it be easier to make fdecl == DECL_ORIGIN (fdecl) earlier in > > the >> >>

Re: [google] Enhance Annotalysis to support cloned functions/methods (issue4591066)

2011-06-13 Thread lcwu
http://codereview.appspot.com/4591066/diff/3001/gcc/tree-threadsafe-analyze.c File gcc/tree-threadsafe-analyze.c (right): http://codereview.appspot.com/4591066/diff/3001/gcc/tree-threadsafe-analyze.c#newcode1159 gcc/tree-threadsafe-analyze.c:1159: gcc_assert (false); On 2011/06/11 17:52:51, Dieg

Re: [google] Enhance Annotalysis to support cloned functions/methods (issue4591066)

2011-06-11 Thread dnovillo
OK with some minor nits. Diego. http://codereview.appspot.com/4591066/diff/3001/gcc/tree-threadsafe-analyze.c File gcc/tree-threadsafe-analyze.c (right): http://codereview.appspot.com/4591066/diff/3001/gcc/tree-threadsafe-analyze.c#newcode1159 gcc/tree-threadsafe-analyze.c:1159: gcc_assert (

[google] Enhance Annotalysis to support cloned functions/methods (issue4591066)

2011-06-10 Thread Le-Chun Wu
Just identified a bug in my previous patch after running the compiler on google code base. Basically the difference from the previous patch is for the compiler to handle the case where the parameters of a cloned method are optimized away. Bootstrapped OK. Testing is still on-going. OK for google/m

[google] Enhance Annotalysis to support cloned functions/methods (issue4591066)

2011-06-10 Thread Le-Chun Wu
Enhance Annotalysis to support cloned functions/methods (especially created by IPA-SRA). The patch basically does the following: 1. For a FUNCTION_DECL, check whether it's a clone, and if so, grab its original DECL. 2. Deal with the situation where a reference/pointer parameter is converted to a v