Zero-length variable-length-arrays are not allowed in standard C99,
and perhaps more importantly, they cause ASAN to complain. (See,
e.g., https://gcc.gnu.org/ml/gcc-patches/2013-09/msg00917.html.)
With this patch, the libiberty tests, including demangler-fuzzer, are
ASAN-clean.
- Brooks
Ping?
(I suspect I should have added a libiberty maintainer to cc in the first place.)
On Mon, Jun 13, 2016 at 9:05 AM, Brooks Moses wrote:
> Zero-length variable-length-arrays are not allowed in standard C99,
> and perhaps more importantly, they cause ASAN to complain. (See,
> e.g., https://gc
On Mon, Jul 11, 2016 at 1:05 PM, Brooks Moses wrote:
> Ping?
This is fine, but please add a comment explaining why the code avoids
0-length VLAs. Thanks.
Ian
> (I suspect I should have added a libiberty maintainer to cc in the first
> place.)
>
> On Mon, Jun 13, 2016 at 9:05 AM, Brooks Moses
On Mon, Jul 11, 2016 at 4:27 PM, Ian Lance Taylor wrote:
> On Mon, Jul 11, 2016 at 1:05 PM, Brooks Moses wrote:
>> Ping?
>
> This is fine, but please add a comment explaining why the code avoids
> 0-length VLAs. Thanks.
Thanks!
Committed as r238233. This is the comment I added:
+/* Avoid