Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-08-04 Thread H.J. Lu
On Fri, Aug 3, 2012 at 10:09 AM, Thomas Koenig wrote: > Hi, > >> OK for trunk? > > > I will be on holiday starting tomorrow, so I would like to commit > this today, if possible (with a mistake in the ChangeLog noted > by Uros fixed. Thanks!) > > If not, somebody please commit this (or another fix

Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-08-03 Thread Thomas Koenig
Hi, OK for trunk? I will be on holiday starting tomorrow, so I would like to commit this today, if possible (with a mistake in the ChangeLog noted by Uros fixed. Thanks!) If not, somebody please commit this (or another fix). Thomas

Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-08-02 Thread Thomas Koenig
Hi Tobias, > I am not sure whether it is the best solution, but one possibility would be to ignore -fintrinsic-modules-path for the warning. (That assumes that the warning is (almost) never needed for an installed compiler.) I think this is the right approach. The attached patch does this. Re

Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-08-02 Thread Tobias Burnus
On 08/02/2012 10:54 AM, Richard Guenther wrote: Seems to break testing, all testcases emit Warning: Nonexistent include directory "finclude"^M now and thus all testcases fail like FAIL: gfortran.dg/alloc_comp_basics_1.f90 -O0 (test for excess errors) First, I actually wonder why it only li

Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-08-02 Thread Richard Guenther
On Tue, Jul 31, 2012 at 3:47 PM, Tobias Burnus wrote: > On 07/29/2012 11:24 AM, Thomas Koenig wrote: >> >> here is an updated patch for PR 54033, this time with test cases. >> Thanks to Janis for pointing me in the right direction with these. >> Regression-tested. OK for trunk? > > > Ok. Thanks fo

Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-07-31 Thread Tobias Burnus
On 07/29/2012 11:24 AM, Thomas Koenig wrote: here is an updated patch for PR 54033, this time with test cases. Thanks to Janis for pointing me in the right direction with these. Regression-tested. OK for trunk? Ok. Thanks for the patch - and to Janis for the first review. Can you eliminate the

[patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-07-29 Thread Thomas Koenig
Hello world, here is an updated patch for PR 54033, this time with test cases. Thanks to Janis for pointing me in the right direction with these. Regression-tested. OK for trunk? Thomas 2012-07-29 Thomas König PR fortran/54033 * scanner.c (add_path_to_list): Emit warning if

Re: [patch, fortran] Fix PR 54033, problems with -I

2012-07-27 Thread Janis Johnson
On 07/27/2012 01:06 PM, Thomas Koenig wrote: > Hi Janis, > >> On 07/26/2012 10:16 AM, Thomas Koenig wrote: >> >>> No test case because I couldn't figure out how to test for a >>> warning with no line number. >> >> Try using line number 0. > > That didn't work for me. Using > > ! { dg-do compile

Re: [patch, fortran] Fix PR 54033, problems with -I

2012-07-27 Thread Thomas Koenig
Hi Janis, On 07/26/2012 10:16 AM, Thomas Koenig wrote: No test case because I couldn't figure out how to test for a warning with no line number. Try using line number 0. That didn't work for me. Using ! { dg-do compile } ! { dg-options "-I include_6.f90 -I missing_dir" } ! { dg-warning "n

Re: [patch, fortran] Fix PR 54033, problems with -I

2012-07-26 Thread Janis Johnson
On 07/26/2012 10:16 AM, Thomas Koenig wrote: > No test case because I couldn't figure out how to test for a > warning with no line number. Try using line number 0. Janis

[patch, fortran] Fix PR 54033, problems with -I

2012-07-26 Thread Thomas Koenig
Hello world, the attached, rather obvious patch emits warnings for several cases where there is something wrong with include directories. No test case because I couldn't figure out how to test for a warning with no line number. OK for trunk? Thomas 2012-07-26 Thomas König P