Re: patch, libfortran] [patch, fortran] Fix PR 79956, part two, attempt 3

2017-03-17 Thread Thomas Koenig
Am 17.03.2017 um 17:48 schrieb Markus Trippelsdorf: You should use rdim not sdim in the GFC_ASSERT. Fixed in rev 246248. Sorry for the breakage. Thomas

Re: patch, libfortran] [patch, fortran] Fix PR 79956, part two, attempt 3

2017-03-17 Thread Markus Trippelsdorf
On 2017.03.15 at 00:01 +0100, Thomas Koenig wrote: > Hello world, > > well, here is the third attempt at fixing the second part of the PR. > Glancing over the source, I think there are quite a few places where > we currently issue a runtime error which we could replace by an > assert, but that's

Re: patch, libfortran] [patch, fortran] Fix PR 79956, part two, attempt 3

2017-03-14 Thread Jerry DeLisle
On 03/14/2017 04:01 PM, Thomas Koenig wrote: > Hello world, > > well, here is the third attempt at fixing the second part of the PR. > Glancing over the source, I think there are quite a few places where > we currently issue a runtime error which we could replace by an > assert, but that's

patch, libfortran] [patch, fortran] Fix PR 79956, part two, attempt 3

2017-03-14 Thread Thomas Koenig
Hello world, well, here is the third attempt at fixing the second part of the PR. Glancing over the source, I think there are quite a few places where we currently issue a runtime error which we could replace by an assert, but that's something for 8.0. Regression-tested on x86_64-pc-linux-gnu.

Re: [patch, libfortran] [patch, fortran] Fix PR 79956, part two, attempt 2

2017-03-14 Thread Markus Trippelsdorf
On 2017.03.13 at 23:24 +0100, Thomas Koenig wrote: > Hello world, > > Following Richard's suggestion, I have implemented the GFC_ASSERT macro > and used it to (hopefully) silence the ominous warning and allow > further optimization. Unfortunately the single GFC_ASSERT isn't enough:

[patch, libfortran] [patch, fortran] Fix PR 79956, part two, attempt 2

2017-03-13 Thread Thomas Koenig
Hello world, Following Richard's suggestion, I have implemented the GFC_ASSERT macro and used it to (hopefully) silence the ominous warning and allow further optimization. OK for trunk? Regards Thomas 2017-03-12 Thomas Koenig PR libfortran/79956

[patch, fortran] Fix PR 79956, part two

2017-03-12 Thread Thomas Koenig
Hello world, the attached patch fixes another occurence of PR 79956. In this case, we did sdim = GFC_DESCRIPTOR_RANK (source); .. for (n = 0; n < sdim; n++) { sstride[n] = GFC_DESCRIPTOR_STRIDE(source,n) } Now, we know that sdim can never be zero or