Re: [patch, fortran] Improve dependency checking

2019-07-25 Thread Thomas Koenig
Hi Steve, Ah, I don't speak C++, and didn't know one could corrupt a C prototype in this manner. A quick glance of gfortran.h indeed shows a few more occurences of "bool xxx = false". I suppose the patch is then OK. I don't use many C++ features, but I use this one because I feel it should re

Re: [patch, fortran] Improve dependency checking

2019-07-25 Thread Steve Kargl
On Thu, Jul 25, 2019 at 04:42:44PM +0200, Thomas Koenig wrote: > Hi Steve, > > >> -int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *); > >> +int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *, bool identical > >> = false); > > This is changing the prototype. I would expect to see >

Re: [patch, fortran] Improve dependency checking

2019-07-25 Thread Thomas Koenig
Hi Steve, -int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *); +int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *, bool identical = false); This is changing the prototype. I would expect to see int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *, bool); Usig C++'s optio

Re: [patch, fortran] Improve dependency checking

2019-07-25 Thread Steve Kargl
On Thu, Jul 25, 2019 at 02:57:35PM +0200, Thomas Koenig wrote: > Index: dependency.h > === > --- dependency.h (Revision 273733) > +++ dependency.h (Arbeitskopie) > @@ -37,7 +37,7 @@ int gfc_check_fncall_dependency (gfc_expr *

[patch, fortran] Improve dependency checking

2019-07-25 Thread Thomas Koenig
Hello world, the attached pach does some more work in gfc_check_dependency for the case where an identity between arguments would also lead to problems. It does not lead to removal of the warning with -Warray-temporaries, because that is still generated by the call to library function. Instead,